bug(table): v2 uses invalid row index to style cell

[wI2L]

Hello,

Per my understanding, the v2 package of Lipgloss table package has introduced the HeaderRow constant to denote the row header.

However, I noticed that in one situation, it still uses the btoi(hasHeaders) function to compute the row index:

lipgloss/table/table.go

Line 310 in ec86e88

renderedCell := t.style(r+btoi(hasHeaders), c).Render(t.data.At(r, c))

Since I cannot find any other usage of this regarding rows, I think this is a regression in v2 introduced with the refactor and introduction of the new constant.

@bashbunni I think you worked on this, so maybe you could correct me if I'm wrong.

Thanks

[bashbunni]

Thanks so much for this - I'm looking into it. One of those funny moments of "it works, but why? 🤔" Will post updates here

[bashbunni]

Update: this is fixed on the table-auto-wrap branch. We weren't accounting for header sizes properly in that conditional block. It's still a WIP branch, but we're fixing a lot of the resizing stuff with Lip Gloss tables. cc @andreynering

https://github.com/charmbracelet/lipgloss/compare/table-auto-wrap

[andreynering]

This should be fixed by #479

[wI2L]

@andreynering Thank you for your work on #479. I'll try it myself, not only for this bug report, with my current project that uses the Lipgloss table package.

[wI2L]

@andreynering Just realised on my side that the branch is based on the v1 module, and I'm currently working off the v2 module.

I'll wait until a backport of the changes in the next v2 alpha/beta release and provide an update if need be.