-
Notifications
You must be signed in to change notification settings - Fork 70
Implement --cpus mapped to QEMU -smp arguments #393
Comments
Whatever we decide, we must also ensure https://github.com/clearcontainers/runtime/blob/master/docs/limitations.md gets updated with the details. |
Ah, indeed, I meant to mention that - once we have implemented this we need to describe at least the non 1:1 mapping limitation on |
I was thinking, maybe when --cpus 1.5 is requested, we should just fail instead of round up to 2. So user will not be confused or misled. How about we support --cpus int as the first step and fix --cpu float in the future if we have better idea how to handle it. |
Yep, I'm happy with that as a first step @wcwxyz Better than no --cpus support at all :-) |
I'd like to get #390 merged before I start working on this one. This |
We should map the
docker run --cpus
request do the QEMU VM command line-smp
argument, as best we can.It cannot be a 1:1 mapping, as
--cpus
takes a float argument, and implements partial CPU quotas using the CFS period and quota settings for instance.A proposal is that we round up to the nearest whole CPU value, for the act of 'least surprise'.
Also see Issue #341 for more background and info, and how this relates in the future to the setup of POD cpu constraints.
The text was updated successfully, but these errors were encountered: