From 50a401564a96f4fce8b1f460c97d959fa054cf84 Mon Sep 17 00:00:00 2001 From: Chelsea Mafrica Date: Mon, 13 Jul 2020 20:28:31 +0000 Subject: [PATCH] virtcontainers: Add to bridges unit test Add function that creates new bridges to increase unit test coverage for virtcontainers/types/bridges. Fixes #2827 Signed-off-by: Chelsea Mafrica --- virtcontainers/types/bridges_test.go | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/virtcontainers/types/bridges_test.go b/virtcontainers/types/bridges_test.go index d8102eaa1d..b171e830bf 100644 --- a/virtcontainers/types/bridges_test.go +++ b/virtcontainers/types/bridges_test.go @@ -43,6 +43,40 @@ func testAddRemoveDevice(t *testing.T, b *Bridge) { } } +func TestAddressFormat(t *testing.T) { + assert := assert.New(t) + + var ccwbridge = NewBridge(CCW, "", make(map[uint32]string), 0) + _, err := ccwbridge.AddressFormatCCW("0") + assert.NoError(err) + _, err = ccwbridge.AddressFormatCCWForVirtServer("0") + assert.NoError(err) + + var pcibridge = NewBridge(PCI, "", make(map[uint32]string), 0) + _, err = pcibridge.AddressFormatCCW("0") + assert.Error(err) + _, err = pcibridge.AddressFormatCCWForVirtServer("0") + assert.Error(err) + +} + +func TestNewBridge(t *testing.T) { + assert := assert.New(t) + + var pci Type = "pci" + var pcie Type = "pcie" + var ccw Type = "ccw" + + var pcibridge = NewBridge(PCI, "", make(map[uint32]string), 0) + assert.Equal(pcibridge.Type, pci, "Type should be PCI") + + var pciebridge = NewBridge(PCIE, "", make(map[uint32]string), 0) + assert.Equal(pciebridge.Type, pcie, "Type should be PCIE") + + var ccwbridge = NewBridge(CCW, "", make(map[uint32]string), 0) + assert.Equal(ccwbridge.Type, ccw, "Type should be CCW") +} + func TestAddRemoveDevicePCI(t *testing.T) { // create a pci bridge