Skip to content
This repository has been archived by the owner on Feb 20, 2025. It is now read-only.

indexer.go in Readme.md is out of date #11

Open
kurobosi opened this issue Apr 19, 2021 · 2 comments
Open

indexer.go in Readme.md is out of date #11

kurobosi opened this issue Apr 19, 2021 · 2 comments

Comments

@kurobosi
Copy link

kurobosi commented Apr 19, 2021

Hi.
Thank your for your kindly-opened your great code.

I've tried to execute your minerva according to your readme.md.
Now I have following errors when I execute "env GOARCH=amd64 GOOS=linux go build -o build/indexer .

---- error starts ----
# indexer
./indexer.go:46:28: too many arguments in call to indexer.RunIndexer
        have (context.Context, events.SQSEvent, *rlogs.Reader)
        want (*rlogs.Reader)
./indexer.go:46:28: indexer.RunIndexer(ctx, event, rlogs.NewReader(logEntries)) used as value
---- error ends ----

It seems that your repository is updated but this "indexer.go" seems to be out of date.
in "9f7ce5c"

function "RunIndexer" has been changed, but your indexer.go does not fit to this update.

Would you take a look at this code?
Thank you.

@m-mizutani
Copy link
Contributor

Thank you for reporting and sorry for late my reply.

As you mentioned, indexer mechanism has been updated. I'm focusing to use indexer as CLI command (assumed to run it on ECS), and indexer of lambda does not work for now. Let me update README and indexer code later.

@kurobosi
Copy link
Author

Hi, thanks for the reply and excuse me for this delayed reply.

Let me update README and indexer code later.

Then I'll keep watching this issues and wait for the update.

Thanks anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants