Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loki/docker compose): enable feature toggle #14858

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

tonypowa
Copy link
Contributor

@tonypowa tonypowa commented Nov 11, 2024

What this PR does / why we need it:

This PR enables the new alert rule creation flow—which is currently behind a feature flag for OSS—for users following the How to create alert rules with log data tutorial.

Note: The reason for specifying the Docker Compose version: "3.3" is that Killercoda, a learning environment used to follow along with the tutorial, seems unable to run more recent versions of Docker Compose files.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@tonypowa tonypowa requested a review from a team as a code owner November 11, 2024 10:38
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler changed the title loki/docker compose: enable feature toggle feat(loki/docker compose): enable feature toggle Nov 13, 2024
@JStickler JStickler merged commit 8f243ee into main Nov 13, 2024
57 checks passed
@JStickler JStickler deleted the tonypowa/loki-docker branch November 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants