From 22d48232002025c89ff2ed9f7637cd2cd16cba1f Mon Sep 17 00:00:00 2001 From: jiangpengfei Date: Sat, 8 Aug 2020 16:00:45 -0400 Subject: [PATCH] virtcontainers: fix delete sandbox failed problem fixes: #2882 reason: If error happens after container create and before sandbox updateResouce in the `CreateContainer()`, then delete sandbox forcefully will return error because s.config.Containers config not flushed into persist store. Signed-off-by: jiangpengfei --- virtcontainers/sandbox.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/virtcontainers/sandbox.go b/virtcontainers/sandbox.go index cdd2aff9d4..32d428941d 100644 --- a/virtcontainers/sandbox.go +++ b/virtcontainers/sandbox.go @@ -1164,6 +1164,10 @@ func (s *Sandbox) CreateContainer(contConfig ContainerConfig) (VCContainer, erro if len(s.config.Containers) > 0 { // delete container config s.config.Containers = s.config.Containers[:len(s.config.Containers)-1] + // need to flush change to persist storage + if newErr := s.storeSandbox(); newErr != nil { + s.Logger().WithError(newErr).Error("Fail to flush s.config.Containers change into sandbox store") + } } } }()