From f2ff670bfbcfe6fdbb477d16f21af6f89c4ceb1a Mon Sep 17 00:00:00 2001 From: Julio Montes Date: Thu, 19 Nov 2020 14:57:53 -0600 Subject: [PATCH] cli: don't fail if rate limit is exceeded Don't fail if rate limit is exceeded since this is a limitation/restriction of Github not a problem in the host. Print a warning when the rate limit is exceeded. For more information about Github's rate limit, see https://developer.github.com/v3/#rate-limiting Signed-off-by: Julio Montes --- cli/release.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/cli/release.go b/cli/release.go index 87e4966124..c86060f9ca 100644 --- a/cli/release.go +++ b/cli/release.go @@ -6,6 +6,7 @@ package main import ( + "bytes" "encoding/json" "errors" "fmt" @@ -276,12 +277,17 @@ func getReleases(releaseURL string, includeAll bool) ([]semver.Version, map[stri releasesArray := []map[string]interface{}{} - bytes, err := ioutil.ReadAll(resp.Body) + body, err := ioutil.ReadAll(resp.Body) if err != nil { return nil, nil, fmt.Errorf("failed to read release details: %v", err) + } else if resp.StatusCode == http.StatusForbidden && bytes.Contains(body, []byte("limit exceeded")) { + // Do not fail if rate limit is exceeded + kataLog.WithField("url", releaseURL). + Warn("API rate limit exceeded. Try again later. Read https://docs.github.com/apps/building-github-apps/understanding-rate-limits-for-github-apps for more information") + return []semver.Version{}, map[string]releaseDetails{}, nil } - if err := json.Unmarshal(bytes, &releasesArray); err != nil { + if err := json.Unmarshal(body, &releasesArray); err != nil { return nil, nil, fmt.Errorf("failed to unpack release details: %v", err) }