Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Cloud Hypervisor: kill virtiofsd not working properly #2270

Closed
ericooper opened this issue Nov 26, 2019 · 1 comment
Closed

Cloud Hypervisor: kill virtiofsd not working properly #2270

ericooper opened this issue Nov 26, 2019 · 1 comment
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@ericooper
Copy link
Contributor

Description of problem

A typo (minus sign in front of the pid) has been introduced in the line responsible for killing the virtionfsd when the hypervisor fails to start hence leaving processes running unnecessary.

syscall.Kill(-clh.state.VirtiofsdPID, syscall.SIGKILL)

Expected result

virtiofsd should be killed properly

Actual result

it doesn't get killed due to the typo in the source code

I'll fix this in the next upcoming PR for clh hence this one can be assigned to me.

@ericooper ericooper added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Nov 26, 2019
@jodh-intel
Copy link
Contributor

Interesting as that looks like valid code (which is trying to kill all processes in the process group whose ID is the value of clh.state.VirtiofsdPID).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

2 participants