Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

remove "default hypervisor" message from build #2785

Closed
egernst opened this issue Jun 19, 2020 · 8 comments · Fixed by #3092
Closed

remove "default hypervisor" message from build #2785

egernst opened this issue Jun 19, 2020 · 8 comments · Fixed by #3092
Assignees
Labels
bug Incorrect behaviour good-first-issue Small and simple task for new contributors

Comments

@egernst
Copy link
Member

egernst commented Jun 19, 2020

AFAIU, there really isn't a notion of "default" VMM for Kata. Let's update the build summary to remove this:

• hypervisors:
	Default: qemu
	Known: acrn cloud-hypervisor firecracker qemu qemu-virtiofs
	Available for this architecture: acrn cloud-hypervisor firecracker qemu qemu-virtiofs

We should be able to remove the Default line, and keep the remaining.

@egernst egernst added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jun 19, 2020
@ariel-adam ariel-adam added good-first-issue Small and simple task for new contributors and removed needs-review Needs to be assessed by the team. labels Sep 1, 2020
@bporter816
Copy link
Contributor

Hi! @tommyrousey, @maomarcus, and @yasv123 and I are students at UT Austin, and we're looking to make some open source contributions over the course of the rest of the year as a part of our virtualization class. Could we be assigned to this issue?

@bporter816
Copy link
Contributor

bporter816 commented Dec 1, 2020

@egernst @jodh-intel @ariel-adam @fidencio We will be completing this issue soon and were wondering if there are any functional changes that need to happen outside of removing references to DEFAULT_HYPERVISOR from the Makefile.

@egernst
Copy link
Member Author

egernst commented Dec 1, 2020

Hey there @bporter816! I don't think there are any functional changes required; just cleanup/removal for this one.

@egernst
Copy link
Member Author

egernst commented Dec 1, 2020

And, sorry for not responding in September! Thanks for the help!

@egernst
Copy link
Member Author

egernst commented Dec 1, 2020

If you're interested, we can see if there are more interesting issues within the code base for you :)

@bporter816
Copy link
Contributor

@egernst Yes, that would be great! We would love to pick up another issue. Please let us know if you're aware a good one we could scope out that would take about a week to complete.

@egernst
Copy link
Member Author

egernst commented Dec 2, 2020

@egernst Yes, that would be great! We would love to pick up another issue. Please let us know if you're aware a good one we could scope out that would take about a week to complete.

Yes - will do! TAL @ #3093

@liubin
Copy link
Member

liubin commented Dec 4, 2020

@bporter816 Thanks, you can also filter issues by label good-first-issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour good-first-issue Small and simple task for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants