This repository has been archived by the owner on May 12, 2021. It is now read-only.
listInterfaces() will fail to report errors from convertToInterfaces() #3032
Labels
bug
Incorrect behaviour
needs-forward-port
Changes need to be applied to a newer branch / repository
needs-review
Needs to be assessed by the team.
Description of problem
Problem pointed out by @amshinde at #3003 (review)
In #3003 we allowed
convertToInterfaces()
to fail, but a bug in the implementation means thatlistInterfaces()
doesn't properly propagate an error here to the caller.Expected result
Errors reported by
convertToInterfaces()
are reported to the caller oflistInterfaces()
.Actual result
Errors reported by
convertToInterfaces()
will be lost andlistInterfaces()
will report an empty list and no error.Further information
When looking at this, I noticed there's also a pre-existing bug where if the upcast to
*grpc.Interfaces
fails we'll also report no error. There are several other bugs with the same pattern inkata_agent.go
. I'll try to address those too.The text was updated successfully, but these errors were encountered: