Add validation tests for Apparmor #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XXL
feiskyer
force-pushed
the
apparmor-validate
branch
from
721d2a0 to
e02d7ce
Compare
k8s-ci-robot
added
size/L
feiskyer
changed the title
|
Update: actually only one function is used from |
feiskyer
force-pushed
the
apparmor-validate
branch
from
e02d7ce to
f9e5282
Compare
Random-Liu
reviewed
Sep 20, 2017
pkg/validate/apparmor.go
Outdated
| ` | ||
| ) | ||
|
|
||
| var _ = framework.KubeDescribe("Security Context", func() { |
There was a problem hiding this comment.
So we could have different describe with the same name? Didn't know that
There was a problem hiding this comment.
Hmm, should be Apparmor here.
Random-Liu
reviewed
Sep 20, 2017
| // isAppArmorEnabled returns true if apparmor is enabled for the host. | ||
| // This function is forked from | ||
| // https://github.com/opencontainers/runc/blob/1a81e9ab1f138c091fe5c86d0883f87716088527/libcontainer/apparmor/apparmor.go | ||
| // to avoid the libapparmor dependency. |
There was a problem hiding this comment.
Add TODO to reuse the function after we could properly sync api?
feiskyer
force-pushed
the
apparmor-validate
branch
from
f9e5282 to
7503c46
Compare
|
@Random-Liu Addressed comments, PTAL |
feiskyer
force-pushed
the
apparmor-validate
branch
from
7503c46 to
1dcefa6
Compare
|
LGTM |
Random-Liu
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24.
Seems apiextensions-apiserver hasn't synced recently, so
k8s.io/apiextensions-apiserver/pkg/featureswill not be found in any packages and updating vendors fork8s.io/apiextensions-apiserverwill reportWARNING: package k8s.io/apiextensions-apiserver is unused, consider removing it from vendor.conf.