[11.x] Ensure that events are fired when bulk dispatching jobs onto the database queue #54658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A breaking change to make this multiple queries imo. |
|
@taylorotwell: Would you still consider it a breaking change if we manage to wrap the queries into a single transaction? Or would you be open to merge this into another (future) major Laravel release? I've been experimenting extensively with fixing #52689 without splitting the insert statement, but it's not trivial. The main issue is that we can't easily retrieve the IDs of the newly inserted rows from the jobs table, which are necessary to dispatch the JobQueued events. I've put together a proof of concept here: 11.x...lukasmu:framework:fixes-52689-variation Thanks for your consideration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52689 by removing the custom bulk method from the
DatabaseQueueclass. The default implementation of the bulk method from the abstractQueueclass will now be used.Benefits:
DatabaseQueueclass has fewer lines of code now.Drawback:
In my opinion, the benefits clearly outweigh the drawback. Consistency is more important than performance in this case, and performance can still be optimized by wrapping the bulk method in a transaction when necessary.
One unit test was slightly modified to accommodate this change, and an integration test was added.