Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRs are not mergeable due to the pending code-review/pullapprove #1174

Closed
AkihiroSuda opened this issue Jan 11, 2023 · 3 comments
Closed

PRs are not mergeable due to the pending code-review/pullapprove #1174

AkihiroSuda opened this issue Jan 11, 2023 · 3 comments

Comments

@AkihiroSuda
Copy link
Member

PRs are not mergeable due to the pending code-review/pullapprove

image
#1169 (comment)

This should be removable in https://github.com/opencontainers/runtime-spec/settings (Branches → Branch protection rules), but it looks like I don't have an access to https://github.com/opencontainers/runtime-spec/settings (although I have an access to https://github.com/opencontainers/runc/settings .)
@AkihiroSuda
Copy link
Member Author

@caniszczyk @amye PTAL 🙏

@amye
Copy link

amye commented Jan 18, 2023

Try it now, we probably need to change these settings.

@AkihiroSuda
Copy link
Member Author

Thank you!

Looks like the merge button is now clickable but the pullaprove check still appears in the "Some checks haven’t completed yet" section. Can we just completely disable it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amye @AkihiroSuda