Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate: duplicate environment variables #30

Closed
cyphar opened this issue Nov 11, 2016 · 1 comment
Closed

generate: duplicate environment variables #30

cyphar opened this issue Nov 11, 2016 · 1 comment
Labels
bug oci/generate upstream
Milestone
0.0.0

Comments

@cyphar
Copy link
Member

cyphar commented Nov 11, 2016

When we generate the rspec.Spec, we append to the environment variable set. This is a bit dangerous, and the more sane thing to do would be to overwrite variables if necessary. It would be nice if this was implemented upstream though...
@cyphar cyphar added this to the 0.0.0 milestone Nov 11, 2016
@cyphar
Copy link
Member Author

cyphar commented Dec 14, 2016

This is the upstream issue: opencontainers/runtime-tools#290

@cyphar cyphar closed this as completed in 1d73d64 Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug oci/generate upstream
Projects
None yet
Milestone
0.0.0
Development

No branches or pull requests
1 participant
@cyphar