salt.states.file should support relative/symbolic modes

[brevilo]

The salt.states.file module allows to set file/directory permissions by specifying common numerical UNIX mode values (see file and directory functions). In contrast to chmod, however, it doesn't support relative or symbolic mode values like g+w. Thus one can only modify permissions as a whole, not individual bits (without workarounds like salt.states.cmd.run).

[ssgward]

@brevilo - thanks. We'll label this as a feature as the described functionality for relative or symbolic values currently does not exist (that we know of) and needs to be added. If we find that the functionality does exist and it's just not working we can go back and label this a bug.

[ssgward]

@brevilo - feel free to create a PR to add this functionality

[brevilo]

We'll label this as a feature

Yep, as intended.

[ferricoxide]

It will be noted in this bug when this feature is implemented, correct? Got something that this functionality would be great for. =)

At any rate, 👍 for the desired functionality.

[boltronics]

I'd love to see this implemented. Currently I've got to use something like chmod -R u=rwX,g=rX,o-rwx in a cmd.run block instead of file.directory state module with the mode and recurse arguments, since I only want directories to be user+group executable as well as any files that are already executable, for example.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[boltronics]

This is still a problem.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[boltronics]

I think this functionality is still missing, based on a skim of the file state module documentation. https://docs.saltstack.com/en/latest/ref/states/all/salt.states.file.html

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[pepoluan]

No progress on this after 2 years?

[TimidRobot]

Given that file permissions are a fundamental building block of security, I think that calling this issue a "feature" is inaccurate. This is a bug 🐛

This issue is still present. For example:

salt/salt/utils/files.py

Lines 739 to 754 in b45c319

	def normalize_mode(mode):
	"""
	Return a mode value, normalized to a string and containing a leading zero
	if it does not have one.
	Allow "keep" as a valid mode (used by file state/module to preserve mode
	from the Salt fileserver in file states).
	"""
	if mode is None:
	return None
	if not isinstance(mode, str):
	mode = str(mode)
	mode = mode.replace("0o", "0")
	# Strip any quotes any initial zeroes, then though zero-pad it up to 4.
	# This ensures that somethign like '00644' is normalized to '0644'
	return mode.strip('"').strip("'").lstrip("0").zfill(4)

[ferricoxide]

This issue is still present.

It's more than a skosh disheartening that this ticket is still open given that I first started following it back in 2016 (over seven years ago, now, and a couple months shy my issue-join's 7th anniversary, at this point)

[bdrx312]

I think part of the problem is that the python builtin sdk does not provide this functionality so you either have to write your own logic or use a module like https://github.com/linsomniac/symbolicmode.