Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework and enable tests for Merels. #433

Open
amanagr opened this issue Jun 10, 2018 · 43 comments · May be fixed by #852
Open

Rework and enable tests for Merels. #433

amanagr opened this issue Jun 10, 2018 · 43 comments · May be fixed by #852
Labels
good first issue help wanted

Comments

@amanagr
Copy link
Member

amanagr commented Jun 10, 2018 •
edited
Loading

Merels was ported to game_handler recently, but it's tests were not revised. They need to be reworked. Tests for connect_four bot can serve as good examples for how to modify the tests for Merels.

merels.py was totally changed so write new set of tests for it. Files in libraries were not much changed so they need to be tweaked to accomodate for the changes.

Enable testing for merels by adding __init__.py file to the directory.
@amanagr amanagr mentioned this issue Jun 10, 2018
Closed
@neiljp
Copy link
Contributor

neiljp commented Jun 10, 2018

See the following for a good first commit to work from: bd945c3

@JordanTroutman
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @JordanTroutman! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@JordanTroutman
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jul 3, 2018 •
edited
Loading

Hello @dsolisherrera, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@JordanTroutman
Copy link
Collaborator

Issue waiting for pull rquest

@zulipbot
Copy link
Member

zulipbot commented Jul 13, 2018 •
edited
Loading

Hello @JordanTroutman, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@dsolisherrera
Copy link
Collaborator

Hi, this seems like a good issue to get involved. I would like to take a look.

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @dsolisherrera! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@dsolisherrera
Copy link
Collaborator

@zulipbot claim

@dsolisherrera
Copy link
Collaborator

Hi @amanagr, is there a place where I can find documentation on this bot?
I was able to make the tests run based on the comment from neiljp. But I would like to see what it does and understand it before starting to modify the tests.

@amanagr
Copy link
Member Author

amanagr commented Aug 29, 2018

There is no documentation for the Merels bot. You can look at comments and git history of the code for some. You should first try to understand how tests for other bots are written, then it will be a lot easier to grab this one.

@bymayanksingh
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @code-monk08! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Jan 24, 2019 •
edited
Loading

Hello @sjha2048, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@bymayanksingh
Copy link
Collaborator

@zulipbot abandon

@aditisingh2362
Copy link
Collaborator

@zulipbot abandon

@vinitwadgaonkar
Copy link
Collaborator

@zulipbot claim

@vinitwadgaonkar vinitwadgaonkar removed their assignment Jan 27, 2021
@nagyem
Copy link
Collaborator

nagyem commented Nov 10, 2022

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @nagyem! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@nagyem
Copy link
Collaborator

nagyem commented Nov 10, 2022

@zulipbot abandon

@Freedisch
Copy link

Freedisch commented Nov 26, 2022 •
edited
Loading

hello, I'm new to open source and wanted to contribute to this issue. This issue is still open, but it seems it has already been solved. Or is there something else to fix in it?
https://github.com/zulip/python-zulip-api/blob/main/zulip_bots/zulip_bots/bots/merels/test_merels.py

@avijitdas126
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @avijitdas126! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

avijitdas126 added a commit to avijitdas126/python-zulip-api that referenced this issue Jan 31, 2025
@avijitdas126
fix:Rework and enable tests for Merels. zulip#433
73725ec
@avijitdas126 avijitdas126 linked a pull request Jan 31, 2025 that will close this issue
Open
12 tasks
@avijitdas126
Copy link
Collaborator

@zulipbot abandon

avijitdas126 added a commit to avijitdas126/python-zulip-api that referenced this issue Feb 3, 2025
@avijitdas126
Fix: Rework and enable tests for Merels bot zulip#433
18bce88 
This commit fixes and enables the test suite for the Merels bot by addressing import issues, updating test execution paths, and ensuring compatibility with the Zulip bot framework.
@Yash-Singh-Pathania
Copy link

Can work on this
@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 5, 2025

Welcome to Zulip, @Yash-Singh-Pathania! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix:Rework and enable tests for Merels. #433 avijitdas126/python-zulip-api