Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable gc for crd ipam #706

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Oct 21, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG October 21, 2024 11:56
@l1b0k l1b0k force-pushed the feat/update_gc branch 2 times, most recently from 1c2e398 to 714ab7b Compare October 21, 2024 12:09
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 70 lines in your changes missing coverage. Please review.

Project coverage is 19.78%. Comparing base (542a887) to head (06b3c20).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
daemon/daemon.go 0.00% 31 Missing ⚠️
daemon/daemon_linux.go 0.00% 15 Missing ⚠️
daemon/builder.go 0.00% 4 Missing ⚠️
pkg/eni/manager.go 0.00% 4 Missing ⚠️
plugin/datapath/policy_router_linux.go 42.85% 3 Missing and 1 partial ⚠️
plugin/datapath/ipvlan_linux.go 50.00% 2 Missing and 1 partial ⚠️
pkg/eni/crdv2.go 0.00% 2 Missing ⚠️
pkg/eni/remote.go 0.00% 2 Missing ⚠️
pkg/eni/trunk.go 0.00% 2 Missing ⚠️
plugin/driver/utils/utils_linux.go 84.61% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   19.85%   19.78%   -0.07%     
==========================================
  Files         123      123              
  Lines       16809    16863      +54     
==========================================
- Hits         3337     3336       -1     
- Misses      13096    13149      +53     
- Partials      376      378       +2     
Flag Coverage Δ
unittests 19.78% <22.22%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit b408c2f into AliyunContainerService:main Oct 21, 2024
9 checks passed
@l1b0k l1b0k deleted the feat/update_gc branch October 22, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants