Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: migrate to url endpoint #745

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Dec 25, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG December 25, 2024 03:31
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 60.90226% with 52 lines in your changes missing coverage. Please review.

Project coverage is 22.36%. Comparing base (1c70388) to head (d248a61).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cert/webhook.go 61.36% 42 Missing and 9 partials ⚠️
cmd/terway-controlplane/terway-controlplane.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   21.50%   22.36%   +0.86%     
==========================================
  Files         121      121              
  Lines       15915    15964      +49     
==========================================
+ Hits         3422     3571     +149     
+ Misses      12110    11993     -117     
- Partials      383      400      +17     
Flag Coverage Δ
unittests 22.36% <60.90%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the feat/webhook_migrate branch 2 times, most recently from a5aca20 to 1c4aa0b Compare December 25, 2024 06:19
@l1b0k l1b0k force-pushed the feat/webhook_migrate branch from 1c4aa0b to d248a61 Compare December 25, 2024 07:03
@BSWANG BSWANG merged commit e05347b into AliyunContainerService:main Dec 25, 2024
9 checks passed
@l1b0k l1b0k deleted the feat/webhook_migrate branch December 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants