Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to go1.24 #3467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update to go1.24 #3467

wants to merge 1 commit into from

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Mar 3, 2025

notably, this kills hack/tools in favor of the new tools directive in the go.mod.
Go 1.24 now has FIPS certification of the 1P crypto, but we are currently still required to use MSFT Go...

@Copilot Copilot bot review requested due to automatic review settings March 3, 2025 21:46
@rbtr rbtr requested a review from rayaisaiah March 3, 2025 21:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Go version configuration across multiple CI workflows to align with the upgrade to Go 1.24, while also removing an obsolete tools registration file and updating some dependency configurations.

  • Update go-version settings from fixed version ranges (e.g. "^1.23") to non-deterministic strings ("latest" or "stable").
  • Remove the build/tools/tools.go file, which previously imported various tool dependencies.
  • Adjust the invocation of go-junit-report in unit test pipelines.

Reviewed Changes

File Description
.github/workflows/cyclonus-netpol-extended-nightly-test.yaml Updated go-version from "^1.23" to "latest" for Go version configuration.
.github/workflows/cyclonus-netpol-test.yaml Updated go-version from '^1.23' to "latest".
.github/workflows/golangci.yaml Switched go-version to "stable" and updated golangci-lint version to "latest".
.github/workflows/codeql.yaml Updated go-version from "1.23" to "latest".
.github/dependabot.yaml Removed a dependency block for "/build/tools".
.github/workflows/crdgen.yaml Removed matrix configuration and set a fixed runner and go-version to "stable".
.pipelines/templates/unit-tests.stages.yaml Changed go-junit-report invocation to use "go tool go-junit-report".
.pipelines/templates/run-unit-tests.yaml Changed go-junit-report invocation to use "go tool go-junit-report".
build/tools/tools.go Deleted file registering tool dependencies.

Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

build/tools/tools.go:1

  • Removal of the tools.go file may affect dependencies on tool registration; please verify that no parts of the build or tooling process rely on these imports.
package tools

Signed-off-by: Evan Baker <[email protected]>
@rbtr rbtr enabled auto-merge March 3, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant