Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gymnasium v1.1.0 #2095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pseudo-rnd-thoughts
Copy link
Contributor

Description

Add support for Gymnasium v1.1.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

@pseudo-rnd-thoughts
Copy link
Contributor Author

The largest change as to the vector environment autoreset modes in v1.1.0 however as Sb3 contains its own custom vector environment implementation then this shouldn't matter.

@araffin
Copy link
Member

araffin commented Mar 3, 2025

Hello,
thanks for the PR =)
Could you check that the SB3 contrib passes too?
https://github.com/Stable-Baselines-Team/stable-baselines3-contrib

because I saw that the behavior of get_wrapper_attr and set_wrapper_attr changed.

@pseudo-rnd-thoughts
Copy link
Contributor Author

because I saw that the behavior of get_wrapper_attr and set_wrapper_attr changed.

Yes, this was a bug fix and new feature upgrade to the function.

@pseudo-rnd-thoughts
Copy link
Contributor Author

Could you check that the SB3 contrib passes too?

Stable-Baselines-Team/stable-baselines3-contrib#280 seem to be no issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants