Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set minimum rustc version to 1.82 #957

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

mmoskal
Copy link
Contributor

@mmoskal mmoskal commented Dec 1, 2024

The is_none_or function was introduced in 1.82.

BTW, maybe we need 1.83?

Copy link

github-actions bot commented Dec 1, 2024

Code Metrics Report
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 C Header                2           35           28            0            7
 Dockerfile              1           41           22           10            9
 Happy                   1          442          369            0           73
 JSON                   12          105          104            0            1
 Python                 57         2435         2094           67          274
 Shell                   1           57           22           18           17
 Plain Text              3         3723            0         2413         1310
 TOML                   18          593          528            2           63
 YAML                    2           21           19            2            0
-------------------------------------------------------------------------------
 Jupyter Notebooks       4            0            0            0            0
 |- Markdown             2           77           32           31           14
 |- Python               2          205          178            1           26
 (Total)                            282          210           32           40
-------------------------------------------------------------------------------
 Markdown               44         3300            0         2499          801
 |- BASH                 6          101           98            0            3
 |- JSON                 1           12           12            0            0
 |- Python               7          121          109            0           12
 |- Rust                12          406          344            0           62
 |- TOML                 2           75           63            0           12
 (Total)                           4015          626         2499          890
-------------------------------------------------------------------------------
 Rust                  289        88491        79398         1842         7251
 |- Markdown           140         1499           25         1366          108
 (Total)                          89990        79423         3208         7359
===============================================================================
 Total                 434        99243        82584         6853         9806
===============================================================================
  

Copy link
Owner

@EricLBuehler EricLBuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@EricLBuehler
Copy link
Owner

Is there something which is requiring 1.83?

It looks like this change of using is_none_or was introduced by using Clippy for 1.83!

@EricLBuehler EricLBuehler merged commit 1983f76 into EricLBuehler:master Dec 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants