Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keg: fix normalize_pod2man_outputs! for compressed manpages #19399

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Feb 28, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Attempting to read gzipped manpages as text results in a cryptic error ArgumentError: invalid byte sequence in UTF-8. A future enhancement would be to decompress compressed manpages to perform the same operation and then re-compress them (or perhaps just reproducibly compress all manpages).

Fixes #19400

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caarlos0
Copy link

I think this might be causing #19400

@alebcay alebcay added this pull request to the merge queue Feb 28, 2025
Merged via the queue into master with commit b390a4d Feb 28, 2025
30 checks passed
@alebcay alebcay deleted the pod2man-shim-fix branch February 28, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't install certain taps that worked before
3 participants