add dynamic year display #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bashamega
approved these changes
Sep 2, 2024
gmta
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Small remark. Two notes:
- The issue states that we "should" do this, but note that displaying a copyright is not a legal requirement.
- We host a static version of the website, so this currently gets compiled to a static year (range) anyway. To update the copyright line for new years, we need to perform a new deployment.
| @@ -93,7 +93,7 @@ | |||
| class="flex sm:flex-row flex-col gap-10 items-center justify-between py-[30px] pb-5 px-0 border-t-[#303030] border-t-[1px] mt-8 border-solid" | |||
| > | |||
| <div class="[&>p]:text-[#404040] font-normal"> | |||
| <p>© 2024. All rights reserved.</p> | |||
| <p>© {new Date().getFullYear()}. All rights reserved.</p> | |||
There was a problem hiding this comment.
Since we do not suddenly stop hosting content from 2024, this should probably be a date range.
There was a problem hiding this comment.
true ; with inside of the founding year => 2024 - {new Date().getFullYear()}
Thanks for clarifying @gmta I understand about the static deployment and optional update. Let me know if there’s anything else to adjust :) |
|
Hi @gmta. What is the status on it and proposed solution? It would be great to have a current year in footer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #87
Changes made:
In the path: src/components/global/footer.astro
Before:
After:
