-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: connection Flow to use CAIP25 Permission format #29824
Merged
+681
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmcgee725
commented
Jan 21, 2025
ffmcgee725
commented
Jan 21, 2025
ui/components/multichain/pages/review-permissions-page/site-cell/site-cell.tsx
Outdated
Show resolved
Hide resolved
ffmcgee725
commented
Jan 21, 2025
ffmcgee725
commented
Jan 21, 2025
…n request is cancelled
…ons implementation to be fully caip25 compliant
5218ea4
to
f771a58
Compare
ffmcgee725
commented
Jan 23, 2025
Builds ready [1ed1218]
Page Load Metrics (2023 ± 121 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
adonesky1
reviewed
Jan 29, 2025
adonesky1
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FrederikBolding
approved these changes
Jan 29, 2025
Builds ready [a66eac3]
Page Load Metrics (1663 ± 58 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.12.0
Issue or pull request that will be included in release 12.12.0
sip26
team-wallet-api-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For part of our collaboration with the Snaps team to enable Non EVM multichain API we are refactoring the connection flow UI.
The first step to enable this to modify what the connection confirmation UI components receive from the ApprovalController.
Currently they receive an object like this:
Basically the params for a
wallet_requestPermission
request.We want to change this so that instead they receive (and know how to interpret) a CAIP25 formatted request like:
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-01-23.at.17.18.17.mov
NOTE: Don't mind different screens in the UI, this vid is outdated and all UI screens are same as
main
branchBefore
After
Pre-merge author checklist
Pre-merge reviewer checklist