Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert selectors to TypeScript using MetaMaskReduxState as input state type #30648

Draft
wants to merge 21 commits into
base: jongsun/refactor/redux/250221-unflattening-types
Choose a base branch
from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Feb 28, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250221-unflattening-types branch from ff4a6ab to 8579350 Compare February 28, 2025 17:21
@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250228-selectors-typescript-conversion branch from d430462 to d1225d5 Compare February 28, 2025 17:25
@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250228-selectors-typescript-conversion branch from d1225d5 to d68130b Compare February 28, 2025 19:37
@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250228-selectors-typescript-conversion branch from 77a110e to 76762b4 Compare March 3, 2025 10:50
@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250221-unflattening-types branch 3 times, most recently from 054db29 to 21bdbb2 Compare March 3, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants