MF-1099 - Add email subdomain validator #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <[email protected]>
drasko
requested changes
Apr 6, 2020
users/users.go
Outdated
| return false | ||
| } | ||
| domain, ext := hs[0], hs[1] | ||
|
|
||
| // Check subdomain and validate | ||
| if len(hs) == 3 { |
There was a problem hiding this comment.
Why 3? Can there be multiple subdomains (I do not know, but theorethically stere can be sub-subdomain)?
Signed-off-by: Manuel Imperiale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1101 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 95 95
Lines 6760 6769 +9
=======================================
+ Hits 5212 5219 +7
- Misses 1211 1213 +2
Partials 337 337
Continue to review full report at Codecov.
|
Signed-off-by: Manuel Imperiale <[email protected]>
Signed-off-by: Manuel Imperiale <[email protected]>
blokovi
approved these changes
Apr 7, 2020
dborovcanin
approved these changes
Apr 7, 2020
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* MF-1099 - Add email subdomain validator Signed-off-by: Manuel Imperiale <[email protected]> * Add unlimited sub domains Signed-off-by: Manuel Imperiale <[email protected]> * Fix users tests with error nil Signed-off-by: Manuel Imperiale <[email protected]> * Revert users test Signed-off-by: Manuel Imperiale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale [email protected]
Resolves #1099