NOISSUE - Fix Contains function for nil arguments #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
==========================================
- Coverage 77.13% 77.10% -0.03%
==========================================
Files 95 95
Lines 6769 6769
==========================================
- Hits 5221 5219 -2
- Misses 1211 1213 +2
Partials 337 337
Continue to review full report at Codecov.
|
manuio
previously approved these changes
Apr 6, 2020
|
@dusanb94 needs to approve this one |
drasko
dismissed
their stale review
Removin my approval to prevent accidental merge before Dusan reviews.
Signed-off-by: Ivan Milošević <[email protected]>
dborovcanin
previously approved these changes
Apr 7, 2020
dborovcanin
approved these changes
Apr 7, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Ivan Milošević <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milošević [email protected]
What does this do?
Fix bug in Contains function in error package.
Bug was that Contains would return
truewhen second argument isnilregardless on value of first argumentWhich issue(s) does this PR fix/relate to?
No issue