MF-1115 - Improve the SDK error encoding #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
- Coverage 76.14% 75.99% -0.16%
==========================================
Files 96 96
Lines 6888 6806 -82
==========================================
- Hits 5245 5172 -73
+ Misses 1293 1288 -5
+ Partials 350 346 -4
Continue to review full report at Codecov.
|
nmarcetic
reviewed
Apr 15, 2020
| @@ -61,7 +61,7 @@ func (sdk mfSDK) AddBootstrap(key string, cfg BoostrapConfig) (string, error) { | |||
| if err := encodeError(resp.StatusCode); err != nil { | |||
| return "", err | |||
There was a problem hiding this comment.
What if there is an error we don't need to wrap anything? I am not sure how SDK error looks like
There was a problem hiding this comment.
When there is an HTTP error with a mainflux equivalent we only use the custom error. Otherwise we wrap the HTTP message with the custom mainflux error for this kind of function.
mteodor
approved these changes
Apr 15, 2020
dborovcanin
approved these changes
Apr 15, 2020
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Manuel Imperiale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale [email protected]