MF-1125 - Document Provision service #1143

mteodor · 2020-04-26T11:17:51Z

drasko

Does service Swagger file exists?

drasko · 2020-04-26T15:01:10Z

provision/README.md

+```
+
+## Authentication
+In order to create necessary entities provision service needs to authenticate against Mainflux api. To provide authentication credentials to the provision service you can pass it in an environment variable or in a config file as Mainflux user and password or as api token (that can be issued on users/keys endpoint). Additionally users or api token can be passed in Authorization header, this authentication takes precedence over others.


Mainflux API

drasko · 2020-04-26T15:02:08Z

provision/README.md

+
+## Authentication
+In order to create necessary entities provision service needs to authenticate against Mainflux api. To provide authentication credentials to the provision service you can pass it in an environment variable or in a config file as Mainflux user and password or as api token (that can be issued on users/keys endpoint). Additionally users or api token can be passed in Authorization header, this authentication takes precedence over others.
+* MFUser, MFPass  in config or environment


Verbatim these MFUser but it is confusing - what are these? Some variables?

drasko · 2020-04-26T15:02:19Z

provision/README.md

+## Authentication
+In order to create necessary entities provision service needs to authenticate against Mainflux api. To provide authentication credentials to the provision service you can pass it in an environment variable or in a config file as Mainflux user and password or as api token (that can be issued on users/keys endpoint). Additionally users or api token can be passed in Authorization header, this authentication takes precedence over others.
+* MFUser, MFPass  in config or environment
+* MFAPiKEy in config or environment


manuio · 2020-04-27T06:10:50Z

provision/README.md

+Provision service provides an HTTP API to interact with Mainflux. 
+Provision service is used to setup initial applications configuration i.e. things, channels, connections and certificates that will be required for the specific use case. 
+For example lets say you are using a Mainflux and connecting gateways to it. Gateways need an easy way to configure itself for communication with Mainflux (receiving and sending controls and data) and for that you will use bootstrap service but before gateway connects to the bootstrap service configuration needs to be created (things, channels, connections, bootstrap configuration and certificates if mtls is being used). Provision service should provide an easy way of provisioning your gateways. On a gateway there can be many services running and you may require more than one thing and channel to establish all the required means of representing a gateway in your application. Let's say that you are using an [Agent](https://github.com/mainflux/agent) and [Export](https://github.com/mainflux/export) service and you use mtls you will need to provision two things and certificates for those things for access to Mainflux, or you may want to create any number of things and channels for your application, this kind of setup we can call provision layout.
+Provision service provides this feature on a “/mapping” endpoint. Provision layout is configured in [config.toml](configs/config.toml)


Use syntax highlighting /mapping

manuio · 2020-04-27T06:16:55Z

provision/README.md

-PROVISION service provides an HTTP API to interact with Mainflux.
+Provision service provides an HTTP API to interact with Mainflux. 
+Provision service is used to setup initial applications configuration i.e. things, channels, connections and certificates that will be required for the specific use case. 
+For example lets say you are using a Mainflux and connecting gateways to it. Gateways need an easy way to configure itself for communication with Mainflux (receiving and sending controls and data) and for that you will use bootstrap service but before gateway connects to the bootstrap service configuration needs to be created (things, channels, connections, bootstrap configuration and certificates if mtls is being used). Provision service should provide an easy way of provisioning your gateways. On a gateway there can be many services running and you may require more than one thing and channel to establish all the required means of representing a gateway in your application. Let's say that you are using an [Agent](https://github.com/mainflux/agent) and [Export](https://github.com/mainflux/export) service and you use mtls you will need to provision two things and certificates for those things for access to Mainflux, or you may want to create any number of things and channels for your application, this kind of setup we can call provision layout.


I'm not sure that this is correct. and you use mtls you will need to provision two things and certificates for those things for access to Mainflux

manuio · 2020-04-27T06:18:10Z

provision/README.md

+| ----------------------------------- | ------------------------------------------------- | -------------------------------- |
+| MF_PROVISION_USER                   | User (email) for accessing Mainflux               | [email protected]                 |
+| MF_PROVISION_PASS                   | Mainflux password                                 | user123                          |
+| MF_PROVISION_API_KEY                | Mainflux authentication token                     | ""                               |


Remove "" from default value

manuio · 2020-04-27T06:18:27Z

provision/README.md

+| MF_PROVISION_API_KEY                | Mainflux authentication token                     | ""                               |
+| MF_PROVISION_CONFIG_FILE            | Provision config file                             | "config.toml"                    |


Same here and for all others

manuio · 2020-04-27T06:23:13Z

provision/README.md

+      "ID": "c22b0c0f-8c03-40da-a06b-37ed3a72c8d1",
+      "Owner": "",
+      "Name": "thing",
+      "Key": "007cce56-e0eb-40d6-b2b9-ed348a97d1eb",
+      "Metadata": {
+        "externalID": "33:52:79:C3:43"


id, owner, name etc etc

this is result of marshalling things.Thing should we add json tags to that structure maybe?

Yes, you need JSON tags. We don't use camelCase for JSON keys

Maybe you can do something like here: https://github.com/mainflux/mainflux/blob/master/things/api/things/http/responses.go#L39

It should be ok now with this: https://github.com/mainflux/mainflux/pull/1146

manuio · 2020-04-27T06:23:59Z

provision/README.md

+`/mapping` endpoint provision layout can be configured.
+
+In `config.toml` we can enlist array of things and channels that we want to create and make connections between them which we call provision layout.
+Metadata can be whatever suits your needs except that at least one thing needs to have `externalID` (which is populated with value from [request](#example)).


external_id

this how it is in thing metadata

Then it have to be also fixed in thing metadata

this requires additional issue since bootstrap service needs to be changed as well

Why? https://github.com/mainflux/mainflux/blob/master/bootstrap/api/responses.go#L73

manuio · 2020-04-27T06:26:04Z

provision/README.md

+```
+docker-compose -f docker/addons/provision/docker-compose.yml up
+```
+or


manuio · 2020-04-27T06:26:48Z

provision/README.md

+MF_PROVISION_BS_SVC_URL=http://localhost:8202/things MF_PROVISION_THINGS_LOCATION=http://localhost:8182 MF_PROVISION_USERS_LOCATION=http://localhost:8180 MF_PROVISION_CONFIG_FILE=docker/addons/provision/configs/config.toml build/mainflux-provision
+```
+
+For the case that credentials or api token is passed in configuration


manuio · 2020-04-27T06:27:09Z

provision/README.md

+curl -s -S  -X POST  http://localhost:8888/mapping  -H 'Content-Type: application/json' -d '{ "external_id" : "33:52:77:99:43", "external_key":"223334fw2" }'
+```
+
+In the case that provision service is not deployed with credential or you want to use user other than default one being set in environment ( or config file)


Remove the white space here: ( or config file)

mteodor · 2020-04-27T07:32:23Z

Does service Swagger file exists?
https://github.com/mainflux/mainflux/blob/master/provision/swagger.yml

manuio · 2020-04-27T19:36:11Z

provision/README.md

+docker-compose -f docker/addons/provision/docker-compose.yml up
+```
+
+


rm this blank line

manuio · 2020-04-27T19:37:00Z

provision/README.md

+      "ID": "c22b0c0f-8c03-40da-a06b-37ed3a72c8d1",
+      "Owner": "",
+      "Name": "thing",
+      "Key": "007cce56-e0eb-40d6-b2b9-ed348a97d1eb",
+      "Metadata": {
+        "externalID": "33:52:79:C3:43"


It should be ok now with this: https://github.com/mainflux/mainflux/pull/1146

manuio · 2020-04-27T19:37:36Z

provision/README.md

+
+In the case that provision service is not deployed with credential or you want to use user other than default one being set in environment (or config file)
+```
+curl -s -S  -X POST  http://localhost:8091/mapping -H "Authorization: $TOK" -H 'Content-Type: application/json'   -d '{ "external_id" : "02:42:fE:65:D3:23", "external_key":"223334fw2" }'


Remove the white space here: application/json' -d

manuio · 2020-04-27T19:39:17Z

provision/README.md

+| MF_PROVISION_USER                   | User (email) for accessing Mainflux               | [email protected]                 |
+| MF_PROVISION_PASS                   | Mainflux password                                 | user123                          |
+| MF_PROVISION_API_KEY                | Mainflux authentication token                     |                                  |
+| MF_PROVISION_CONFIG_FILE            | Provision config file                             | "config.toml"                    |


config.toml not "config.toml"

drasko · 2020-04-28T10:14:19Z

provision/README.md

+
+
+## Running
+


Kill this white line

drasko · 2020-04-28T10:14:58Z

provision/README.md

+```
+
+Response contains created things and channels and certificates if any.
+```


Add json label after ```

drasko · 2020-04-28T10:15:20Z

provision/README.md

+In order to create necessary entities provision service needs to authenticate against Mainflux API. To provide authentication credentials to the provision service you can pass it in an environment variable or in a config file as Mainflux user and password or as API token (that can be issued on users/keys endpoint). Additionally users or API token can be passed in Authorization header, this authentication takes precedence over others.
+* `username`, `password` - (`MF_PROVISION_USER`, `MF_PROVISION_PASSWORD` in [.env](../.env), `mf_user`, `mf_pass` in [config.toml](../docker/addons/provision/configs/config.toml))
+* API Key - (`MF_PROVISION_API_KEY` in [.env](../.env) or [config.toml](../docker/addons/provision/configs/config.toml))
+* ```Authorization: Token|ApiKey``` - request authorization header containing either users token or API key


Why triple backticks?

drasko · 2020-04-28T10:15:34Z

provision/README.md

+For channels metadata `type` is reserved for `control` and `data` which we use with [Agent](https://github.com/mainflux/agent).
+
+Example below
+```


Add toml label after ```

drasko · 2020-04-28T10:16:00Z

provision/README.md

+Provision service can be run as a standalone or in docker composition as addon to the core docker composition.
+
+Standalone:
+```


Add bash label after ```

manuio · 2020-04-29T07:12:53Z

provision/README.md

-PROVISION service provides an HTTP API to interact with Mainflux.
+Provision service provides an HTTP API to interact with Mainflux. 
+Provision service is used to setup initial applications configuration i.e. things, channels, connections and certificates that will be required for the specific use case. 
+For example lets say you are using a Mainflux and connecting gateways to it. Gateways need an easy way to configure itself for communication with Mainflux (receiving and sending controls and data) and for that you will use bootstrap service but before gateway connects to the bootstrap service configuration needs to be created (things, channels, connections, bootstrap configuration and certificates if mtls is being used). Provision service should provide an easy way of provisioning your gateways. On a gateway there can be many services running and you may require more than one thing and channel to establish all the required means of representing a gateway in your application. You may need to create any number of things and channels for your purposes, let's say that you are using services [Agent](https://github.com/mainflux/agent) and [Export](https://github.com/mainflux/export) on a gateway, if you enabled mtls each service will need a thing and certificate for access to Mainflux and you will need two channels for `Agent` (`data` and `control`) and for `Export` you could use as many as you find suitable, this kind of setup we can call `provision layout`.


This part is hard to understand. I would simplify it to something like:
For example, to connect Gateways to Mainflux you need an easy way to setup communication channels to send and receive data or control commands. Bootstrap service can be used in this cases but you must previously create Things, Channels, Connections, Bootstrap Config and mTLS certificates. Provision service provide a way to do it so. On a Gateway...
I'm not saying that my proposition is perfect. But your sentences are too long and with too much superfluous.

manuio · 2020-04-29T07:17:01Z

provision/README.md

+docker-compose -f docker/addons/provision/docker-compose.yml up
+```
+
+For the case that credentials or API token is passed in configuration call to endpoint is called:


Sorry, I didn't understand

provision/README.md

manuio · 2020-04-29T15:32:26Z

provision/README.md

-PROVISION service provides an HTTP API to interact with Mainflux.
+Provision service provides an HTTP API to interact with [Mainflux](https://github.com/mainflux/mainflux). 
+Provision service is used to setup initial applications configuration i.e. things, channels, connections and certificates that will be required for the specific use case. 
+For example lets say you are connecting gateways to [Mainflux](https://github.com/mainflux/mainflux). Gateways need an easy way to configure itself for communication with [Mainflux](https://github.com/mainflux/mainflux) (receiving and sending controls and data). To get the authentication parameters gateway will send a request to [Bootstrap](../bootstrap/README.md) service. To get connection parameters gateway will provide `<external_id>` and `<external_key>` in request from [Bootstrap](../bootstrap/README.md). To make a request to [Bootstrap](../bootstrap/README.md) service you can use [Agent](https://github.com/mainflux/agent) service on a gateway. To create bootstrap configuration you can use [Bootstrap](../bootstrap/README.md) or `Provision` service. [Mainflux UI](https://github.com/mainflux/ui) uses [Bootstrap](../bootstrap/README.md) service for creating gateway configurations.  `Provision` service should provide an easy way of provisioning your gateways i.e creating bootstrap configuration and as many things and channels that your setup requires. Also you may use provision service to create certificates for each thing. Each service running on gateway may require more than one thing and channel for communication. Let's say that you are using services [Agent](https://github.com/mainflux/agent) and [Export](https://github.com/mainflux/export) on a gateway, if you enabled mtls each service will need a thing and certificate for access to [Mainflux](https://github.com/mainflux/mainflux) and you will need two channels for `Agent` (`data` and `control`) and one for `Export` or you could use as many as you find suitable, this kind of setup we can call `provision layout`.


Define this link at the bottom of thee README. For example:

This is a [Mainflux][mainflux] link [mainflux]: https://github.com/mainflux/mainflux

Also, probably better to use absolute path for this links

btw, I still not convinced about For example lets say you are connecting...

manuio · 2020-04-29T15:36:08Z

provision/README.md

+docker-compose -f docker/addons/provision/docker-compose.yml up
+```
+
+For the case that credentials or API token is passed in configuration or env, call to `/mapping` endpoint doesnt require `Authentication` header:


We understand or env but maybe better or as environment variable
Also, fix doesn't

codecov-io · 2020-04-29T16:38:44Z

Codecov Report

Merging #1143 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   74.18%   74.18%           
=======================================
  Files         102      102           
  Lines        6841     6841           
=======================================
  Hits         5075     5075           
  Misses       1413     1413           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f872546...450dd87. Read the comment docs.

dborovcanin · 2020-04-29T16:55:10Z

provision/README.md

+| MF_PROVISION_BS_AUTO_WHITEIST       | Should thing be auto whitelisted                  | true                           |
+| MF_PROVISION_BS_CONTENT             | Bootstrap service content                         | {}                             |
+
+By default, call to `/mapping` endpoint will create one thing and two channels (`control` and `data`) and connect it. If there is a requirement for different provision layout we can use [config](docker/configs/config.toml) file in addition to environment variables. For the purposes of running provision as an add-on in docker composition environment variables seems more suitable. Environoment variables are set in [.env](.env).  


Fix typo Environoment.

dborovcanin · 2020-04-29T16:55:31Z

provision/README.md

+`/mapping` endpoint provision layout can be configured.
+
+In `config.toml` we can enlist array of things and channels that we want to create and make connections between them which we call provision layout.
+Metadata can be whatever suits your needs except that at least one thing needs to have `external_id` (which is populated with value from [request](#example)). Thing that has `external_id` will be used for creating boostrap configuration which can be fetched with [Agent](https://github.com/mainflux/agent).


Typo boostrap.

dborovcanin · 2020-04-29T17:01:45Z

provision/README.md

-PROVISION service provides an HTTP API to interact with Mainflux.
+Provision service provides an HTTP API to interact with [Mainflux][mainflux]. 
+Provision service is used to setup initial applications configuration i.e. things, channels, connections and certificates that will be required for the specific use case especially useful for gateway provision. 
+For gateways to communicate with [Mainflux][mainflux] connection params are required (mqtt host, thing, channels, certificates...). To get the connection parameters gateway will send a request to [Bootstrap](../bootstrap/README.md) service providing `<external_id>` and `<external_key>` in request. To make a request to [Bootstrap](../bootstrap/README.md) service you can use [Agent](https://github.com/mainflux/agent) service on a gateway. To create bootstrap configuration you can use [Bootstrap](../bootstrap/README.md) or `Provision` service. [Mainflux UI](https://github.com/mainflux/ui) uses [Bootstrap](../bootstrap/README.md) service for creating gateway configurations.  `Provision` service should provide an easy way of provisioning your gateways i.e creating bootstrap configuration and as many things and channels that your setup requires. Also you may use provision service to create certificates for each thing. Each service running on gateway may require more than one thing and channel for communication. Let's say that you are using services [Agent](https://github.com/mainflux/agent) and [Export](https://github.com/mainflux/export) on a gateway, if you enabled mtls each service will need a thing and certificate for access to [Mainflux][mainflux] and you will need two channels for `Agent` (`data` and `control`) and one for `Export` or you could use as many as you find suitable, this kind of setup we can call `provision layout`.


Maybe use configuration instead of connection params. Maybe also something like this:

To create a bootstrap configuration, you can use Bootstrap service API directly (bootstrap/README.md), or you can use UI or Provision service.

manuio · 2020-04-29T18:59:12Z

provision/README.md

+
+Standalone:
+```bash
+MF_PROVISION_BS_SVC_URL=http://localhost:8202/things MF_PROVISION_THINGS_LOCATION=http://localhost:8182 MF_PROVISION_USERS_LOCATION=http://localhost:8180 MF_PROVISION_CONFIG_FILE=docker/addons/provision/configs/config.toml build/mainflux-provision


Please, split this in multiple lines with \

manuio · 2020-04-29T19:00:37Z

provision/README.md


-PROVISION service provides an HTTP API to interact with Mainflux.
+Provision service provides an HTTP API to interact with [Mainflux][mainflux]. 
+Provision service is used to setup initial applications configuration i.e. things, channels, connections and certificates that will be required for the specific use case especially useful for gateway provision.  


Maybe you can also create references for UI and export links

Signed-off-by: Mirko Teodorovic <[email protected]>

drasko · 2020-04-30T08:44:26Z

provision/README.md


-PROVISION service provides an HTTP API to interact with Mainflux.
+Provision service provides an HTTP API to interact with [Mainflux][mainflux]. 


General observation: break long chunks of text in paragraphs, separate paragraphs with whitelines - it will be much easier to read.

Signed-off-by: Mirko Teodorovic <[email protected]>

drasko · 2020-04-30T11:24:05Z

provision/README.md

+| MF_PROVISION_BS_AUTO_WHITEIST       | Should thing be auto whitelisted                  | true                           |
+| MF_PROVISION_BS_CONTENT             | Bootstrap service content                         | {}                             |
+
+By default, call to `/mapping` endpoint will create one thing and two channels (`control` and `data`) and connect it. If there is a requirement for different provision layout we can use [config](docker/configs/config.toml) file in addition to environment variables. For the purposes of running provision as an add-on in docker composition environment variables seems more suitable. Environment variables are set in [.env](.env).  


Break chunk of text in paragraphs.

drasko · 2020-04-30T11:24:30Z

provision/README.md

+
+## Authentication
+In order to create necessary entities provision service needs to authenticate against Mainflux. To provide authentication credentials to the provision service you can pass it in an environment variable or in a config file as Mainflux user and password or as API token (that can be issued on `/users` or `/keys` endpoint of [authn](../authn/README.md)). Additionally users or API token can be passed in Authorization header, this authentication takes precedence over others.
+* `username`, `password` - (`MF_PROVISION_USER`, `MF_PROVISION_PASSWORD` in [.env](../.env), `mf_user`, `mf_pass` in [config.toml](../docker/addons/provision/configs/config.toml))


Looks like whiteline missing to separate paragraphs.

Signed-off-by: Mirko Teodorovic <[email protected]>

drasko

LGTM

* update readme Signed-off-by: Mirko Teodorovic <[email protected]> * update docs Signed-off-by: Mirko Teodorovic <[email protected]> * small changes Signed-off-by: Mirko Teodorovic <[email protected]> * update docs Signed-off-by: Mirko Teodorovic <[email protected]> * update docs Signed-off-by: Mirko Teodorovic <[email protected]> * update docs Signed-off-by: Mirko Teodorovic <[email protected]> * update docs Signed-off-by: Mirko Teodorovic <[email protected]> * minor changes Signed-off-by: Mirko Teodorovic <[email protected]> * additional paragraphs Signed-off-by: Mirko Teodorovic <[email protected]> * additional paragraphs Signed-off-by: Mirko Teodorovic <[email protected]> * additional paragraphs Signed-off-by: Mirko Teodorovic <[email protected]> * add some space Signed-off-by: Mirko Teodorovic <[email protected]>

mteodor requested a review from a team as a code owner April 26, 2020 11:17

mteodor added the documentation label Apr 26, 2020

mteodor force-pushed the docs-provision branch from fc95b4c to b2126fc Compare April 26, 2020 13:13

drasko requested changes Apr 26, 2020

View reviewed changes

manuio suggested changes Apr 27, 2020

View reviewed changes

mteodor force-pushed the docs-provision branch from b26c655 to f1251c9 Compare April 28, 2020 08:11

mteodor mentioned this pull request Apr 28, 2020

NOISSUE - Update provision service #1133

Merged

drasko requested changes Apr 28, 2020

View reviewed changes

manuio suggested changes Apr 29, 2020

View reviewed changes

blokovi suggested changes Apr 29, 2020

View reviewed changes

provision/README.md Outdated Show resolved Hide resolved

provision/README.md Outdated Show resolved Hide resolved

provision/README.md Show resolved Hide resolved

manuio suggested changes Apr 29, 2020

View reviewed changes

dborovcanin requested changes Apr 29, 2020

View reviewed changes

dborovcanin previously approved these changes Apr 29, 2020

View reviewed changes

manuio suggested changes Apr 29, 2020

View reviewed changes

manuio reviewed Apr 29, 2020

View reviewed changes

mteodor dismissed dborovcanin’s stale review via 12b9768 April 30, 2020 05:20

mteodor added 8 commits April 30, 2020 07:37

update readme

9f30ebb

Signed-off-by: Mirko Teodorovic <[email protected]>

update docs

8bb9ae3

Signed-off-by: Mirko Teodorovic <[email protected]>

small changes

f1aa826

Signed-off-by: Mirko Teodorovic <[email protected]>

update docs

1409404

Signed-off-by: Mirko Teodorovic <[email protected]>

update docs

533f2b7

Signed-off-by: Mirko Teodorovic <[email protected]>

update docs

b2d91ac

Signed-off-by: Mirko Teodorovic <[email protected]>

update docs

b101aa8

Signed-off-by: Mirko Teodorovic <[email protected]>

minor changes

450dd87

Signed-off-by: Mirko Teodorovic <[email protected]>

mteodor force-pushed the docs-provision branch from 12b9768 to 450dd87 Compare April 30, 2020 05:38

drasko requested changes Apr 30, 2020

View reviewed changes

additional paragraphs

02f3ddd

Signed-off-by: Mirko Teodorovic <[email protected]>

drasko requested changes Apr 30, 2020

View reviewed changes

mteodor added 3 commits April 30, 2020 14:01

additional paragraphs

4ad50fd

Signed-off-by: Mirko Teodorovic <[email protected]>

additional paragraphs

93310ad

Signed-off-by: Mirko Teodorovic <[email protected]>

add some space

1c4354d

Signed-off-by: Mirko Teodorovic <[email protected]>

blokovi approved these changes Apr 30, 2020

View reviewed changes

drasko approved these changes Apr 30, 2020

View reviewed changes

drasko merged commit 0c016cd into absmach:master Apr 30, 2020

mteodor deleted the docs-provision branch September 13, 2021 12:26

		\| MF_PROVISION_API_KEY \| Mainflux authentication token \| "" \|
		\| MF_PROVISION_CONFIG_FILE \| Provision config file \| "config.toml" \|

		docker-compose -f docker/addons/provision/docker-compose.yml up
		```


		PROVISION service provides an HTTP API to interact with Mainflux.
		Provision service provides an HTTP API to interact with [Mainflux][mainflux].

MF-1125 - Document Provision service #1143

MF-1125 - Document Provision service #1143

Conversation

mteodor commented Apr 26, 2020 • edited Loading

drasko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mteodor commented Apr 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manuio Apr 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manuio Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Apr 29, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manuio Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

mteodor commented Apr 26, 2020 •

edited

Loading

manuio Apr 27, 2020 •

edited

Loading

manuio Apr 29, 2020 •

edited

Loading

codecov-io commented Apr 29, 2020 •

edited

Loading

manuio Apr 29, 2020 •

edited

Loading