NOISSUE - Use log level error for VermeMQ docker #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 102 102
Lines 6835 6835
=======================================
Hits 5075 5075
Misses 1409 1409
Partials 351 351 Continue to review full report at Codecov.
|
Signed-off-by: Manuel Imperiale <[email protected]>
drasko
reviewed
May 4, 2020
| @@ -208,8 +208,8 @@ services: | |||
| container_name: mainflux-vernemq | |||
| restart: on-failure | |||
| environment: | |||
| DOCKER_VERNEMQ_ALLOW_ANONYMOUS: "on" | |||
| DOCKER_VERNEMQ_LOG__CONSOLE__LEVEL: error | |||
| DOCKER_VERNEMQ_ALLOW_ANONYMOUS: ${MF_DOCKER_VERNEMQ_ALLOW_ANONYMOUS} | |||
There was a problem hiding this comment.
Would ommiting "" here create problem? I guess not, just asking if this was tested?
There was a problem hiding this comment.
AFAIK for docker-compose it's the same. But I didn't deeply tested.
There was a problem hiding this comment.
This will never be off because Manflux doesn't use Broker authentication. IMHO no need for env var.
Signed-off-by: Manuel Imperiale <[email protected]>
Signed-off-by: Manuel Imperiale <[email protected]>
mteodor
approved these changes
May 5, 2020
blokovi
approved these changes
May 5, 2020
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Use log level error for VermeMQ docker Signed-off-by: Manuel Imperiale <[email protected]> * Add vermemq ENVARS Signed-off-by: Manuel Imperiale <[email protected]> * Remove DOCKER_VERNEMQ_ALLOW_ANONYMOUS from docker-compose Signed-off-by: Manuel Imperiale <[email protected]> * Revert DOCKER_VERNEMQ_ALLOW_ANONYMOUS Signed-off-by: Manuel Imperiale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale [email protected]