MF-995 - Add Twins tests for endpoint list twins and list states #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuio
suggested changes
May 13, 2020
manuio
suggested changes
May 13, 2020
manuio
suggested changes
May 13, 2020
manuio
suggested changes
May 13, 2020
manuio
suggested changes
May 13, 2020
darkodraskovic
force-pushed
the
twins_test
branch
3 times, most recently
from
4918318 to
174d4c1
Compare
mteodor
previously approved these changes
May 13, 2020
darkodraskovic
force-pushed
the
twins_test
branch
2 times, most recently
from
9c2b9eb to
f8ad5f8
Compare
darkodraskovic
force-pushed
the
twins_test
branch
2 times, most recently
from
55532a3 to
91a1c1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
+ Coverage 74.71% 77.26% +2.55%
==========================================
Files 102 102
Lines 6854 6814 -40
==========================================
+ Hits 5121 5265 +144
+ Misses 1378 1181 -197
- Partials 355 368 +13
Continue to review full report at Codecov.
|
darkodraskovic
force-pushed
the
twins_test
branch
from
91a1c1c to
7d7c5d5
Compare
Signed-off-by: Darko Draskovic <[email protected]>
… and update Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
darkodraskovic
force-pushed
the
twins_test
branch
from
9c920c6 to
bdabc87
Compare
drasko
requested changes
May 15, 2020
darkodraskovic
force-pushed
the
twins_test
branch
from
bdabc87 to
2389017
Compare
mteodor
reviewed
May 18, 2020
dborovcanin
reviewed
May 18, 2020
Signed-off-by: Darko Draskovic <[email protected]>
darkodraskovic
force-pushed
the
twins_test
branch
from
2389017 to
41ca3e4
Compare
mteodor
previously approved these changes
May 18, 2020
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic <[email protected]>
blokovi
approved these changes
May 18, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add ListTwins test Signed-off-by: Darko Draskovic <[email protected]> * Remove monotonic time from twins, definitions and attributes creation and update Signed-off-by: Darko Draskovic <[email protected]> * Separate twins and states endpoint tests in two files Signed-off-by: Darko Draskovic <[email protected]> * Add state generation helper funcs to state endpoint tests Signed-off-by: Darko Draskovic <[email protected]> * Add createStateResponse() to states test Signed-off-by: Darko Draskovic <[email protected]> * Add states test cases Signed-off-by: Darko Draskovic <[email protected]> * Simplify RetrieveAll twins and states methods Signed-off-by: Darko Draskovic <[email protected]> * Add service.go to mocks Signed-off-by: Darko Draskovic <[email protected]> * Rename mocks.NewService to mocks.New Signed-off-by: Darko Draskovic <[email protected]> * Add error checking to endpoint state tests Signed-off-by: Darko Draskovic <[email protected]> * Fix method comment Signed-off-by: Darko Draskovic <[email protected]> * Add json response decode success check Signed-off-by: Darko Draskovic <[email protected]> * Remove created and updated fields from twin and state res Signed-off-by: Darko Draskovic <[email protected]> * Remove definition fields from twin req and res Signed-off-by: Darko Draskovic <[email protected]> * Add Create funcs to mocks package Signed-off-by: Darko Draskovic <[email protected]> * Add service save state tests Signed-off-by: Darko Draskovic <[email protected]> * Add service list states test Signed-off-by: Darko Draskovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #995