-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Remove twin mqtt related obsolete var and fix es-redis address #1213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 104 104
Lines 6868 6868
=======================================
Hits 5290 5290
Misses 1196 1196
Partials 382 382 Continue to review full report at Codecov.
|
Signed-off-by: Darko Draskovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You can also delete
And this is tested in kubernetes deployment (absmach/devops#52) |
Signed-off-by: Darko Draskovic <[email protected]>
Signed-off-by: Darko Draskovic [email protected]
What does this do?
Removes an obsolete leftover variable related to mqtt notification publishing (removed feature, replaced with NATS publishing) and fixes redis address so twins service can reach redis cache.
List any changes that modify/break current functionality
N/A