NOISSUE - Refactor single-user mode

[dborovcanin]

Signed-off-by: dusanb94 <[email protected]

What does this do?

This pull request refactors single-user mode for Things service.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

Yes.

Did you document any new/modified functionality?

Yes. Docs explaining single-user mode are added.

Notes

N/A

[drasko]

My only cocncern is should this one be called auth, because again when we take a look at things folder in a couple of months and when we see auth - will we know it is a Single-User Mode related module? I was confused like this with previous naming, which was user.

So just one thing to conside - should it be something like singleuser (or something like this, self-documenting), or we leave auth (I am fine with auth also, just challenging the solution a bit).

[dborovcanin]

I actually spent some time thinking about the naming and I decided to go with auth and single_user for go files. The reason is that this is implementation of auth for single_user. It is not ideal, but I find it a bit less confusing than users. Also, standalone sounds a bit better to me than single_user, but I did not want to rename env vars to provide backward compatibility. @drasko What do you think about that auth and standalone?

[drasko]

I think a more detailed documentation in the mainflux/docs repo is needed, with detailed explication how this single-user mode is deployed (Dockerfile) and used.

I.e. - there should be a dedicated chapter (or subsection in Authorization) for Single-User Mode, so that people see and understand that this feature exists (otherwise, it is unnoticed).

[mteodor]

yes, but one paragraph is sufficient for this, since you just set the environment variables and one example how things api is used then, additionally advise to remove auth service from compose when using this mode

[dborovcanin]

I agree with @mteodor, I'd say this is good enough for service README. I'll add suggestion for removing auth from compose and we can add more details in a separate section in docs.

[dborovcanin]

I renamed single-user to standalone, please review.

[drasko]

LGTM

[codecov-commenter]

Codecov Report

Merging #1471 (42ca807) into master (66d3da0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files         123      123           
  Lines        9565     9565           
=======================================
  Hits         6784     6784           
  Misses       2254     2254           
  Partials      527      527           

Impacted Files	Coverage Δ
things/standalone/standalone.go	72.72% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d3da0...42ca807. Read the comment docs.