Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update group sharing policies #1494

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

buraksekili
Copy link
Contributor

@buraksekili buraksekili commented Nov 4, 2021

Signed-off-by: Burak Sekili [email protected]

What does this do?

This PR updates policies created while assigning new members to the Group. So that, instead of having an access relation, now all members will have member relation.

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Update policies

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

No. The doc will be updated.

Notes

@buraksekili buraksekili marked this pull request as ready for review November 5, 2021 11:24
@buraksekili buraksekili requested a review from a team as a code owner November 5, 2021 11:24
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit c70fb57 into absmach:master Nov 8, 2021
fbugarski pushed a commit to fbugarski/mainflux that referenced this pull request Nov 17, 2021
* Update group sharing policies

Signed-off-by: Burak Sekili <[email protected]>

* Replace string with constant

Signed-off-by: Burak Sekili <[email protected]>

Co-authored-by: Drasko DRASKOVIC <[email protected]>
mteodor pushed a commit to mteodor/mainflux that referenced this pull request Dec 23, 2021
* Update group sharing policies

Signed-off-by: Burak Sekili <[email protected]>

* Replace string with constant

Signed-off-by: Burak Sekili <[email protected]>

Co-authored-by: Drasko DRASKOVIC <[email protected]>
bioinformatx pushed a commit to bioinformatx/mainflux that referenced this pull request Jan 28, 2022
* Update group sharing policies

Signed-off-by: Burak Sekili <[email protected]>

* Replace string with constant

Signed-off-by: Burak Sekili <[email protected]>

Co-authored-by: Drasko DRASKOVIC <[email protected]>
Signed-off-by: skovacevic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants