-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Update group sharing policies #1494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Sekili <[email protected]>
Signed-off-by: Burak Sekili <[email protected]>
drasko
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dborovcanin
approved these changes
Nov 8, 2021
drasko
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fbugarski
pushed a commit
to fbugarski/mainflux
that referenced
this pull request
Nov 17, 2021
* Update group sharing policies Signed-off-by: Burak Sekili <[email protected]> * Replace string with constant Signed-off-by: Burak Sekili <[email protected]> Co-authored-by: Drasko DRASKOVIC <[email protected]>
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this pull request
Dec 23, 2021
* Update group sharing policies Signed-off-by: Burak Sekili <[email protected]> * Replace string with constant Signed-off-by: Burak Sekili <[email protected]> Co-authored-by: Drasko DRASKOVIC <[email protected]>
bioinformatx
pushed a commit
to bioinformatx/mainflux
that referenced
this pull request
Jan 28, 2022
* Update group sharing policies Signed-off-by: Burak Sekili <[email protected]> * Replace string with constant Signed-off-by: Burak Sekili <[email protected]> Co-authored-by: Drasko DRASKOVIC <[email protected]> Signed-off-by: skovacevic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Burak Sekili [email protected]
What does this do?
This PR updates policies created while assigning new members to the Group. So that, instead of having an
access
relation, now all members will havemember
relation.Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
Update policies
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
No. The doc will be updated.
Notes