MF-1478 - TimescaleDB writer and reader add-on #1542

corp0529 · 2022-01-11T17:33:28Z

What does this do?

Adds TimescaleDB as a data store

Which issue(s) does this PR fix/relate to?

Resolves #1478

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

Yes

manuio · 2022-01-11T18:40:36Z

@corp0529 Looks like you didn't update vendor (go mod vendor). Can you also check why CI is failling?

drasko · 2022-01-11T20:17:41Z

@corp0529 thanks for this very useful addition! I will review PR carefully in the next few days. @dusanb94, @blokovi, @mteodor and @blokovi please review as well.

Signed-off-by: John Cleasby <[email protected]>

corp0529 · 2022-01-11T20:40:40Z

@manuio Sure, just fixing the CI now, it was the tests not running properly.

codecov-commenter · 2022-01-11T20:50:30Z

Codecov Report

Merging #1542 (f0573e1) into master (bea09d9) will increase coverage by 0.30%.
The diff coverage is 80.13%.

@@            Coverage Diff             @@
##           master    #1542      +/-   ##
==========================================
+ Coverage   67.18%   67.48%   +0.30%     
==========================================
  Files         135      139       +4     
  Lines       11041    11319     +278     
==========================================
+ Hits         7418     7639     +221     
- Misses       3015     3050      +35     
- Partials      608      630      +22

Impacted Files	Coverage Δ
consumers/writers/timescale/consumer.go	`66.99% <66.99%> (ø)`
readers/timescale/messages.go	`84.84% <84.84%> (ø)`
consumers/writers/timescale/init.go	`89.47% <89.47%> (ø)`
readers/timescale/init.go	`89.47% <89.47%> (ø)`
consumers/writers/postgres/consumer.go	`65.76% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea09d9...f0573e1. Read the comment docs.

corp0529 · 2022-01-11T21:08:37Z

@manuio @drasko I've run go mod vendor and there's almost 4k changes in the commit. Shall I leave it as a separate commit or squash with the previous one?

drasko · 2022-01-11T21:15:58Z

@manuio @drasko I've run go mod vendor and there's almost 4k changes in the commit. Shall I leave it as a separate commit or squash with the previous one?

Vendor needs to go in the same PR. Just update your branch with the new commit, all commits are squashed upon merge.

corp0529 · 2022-01-11T22:05:05Z

@manuio @drasko I've run go mod vendor and there's almost 4k changes in the commit. Shall I leave it as a separate commit or squash with the previous one?

Vendor needs to go in the same PR. Just update your branch with the new commit, all commits are squashed upon merge.

It's actually showing no changes after go mod vendor. I've tried a clean pull and go mod vendor and no change.
Everything builds and tests run fine.

manuio · 2022-01-12T07:45:31Z

@corp0529 My bad, looks like there are no new packages used! Thank you for verifying!

cmd/timescale-writer/main.go

consumers/writers/timescale/README.md

docker/addons/timescale-writer/docker-compose.yml

readers/timescale/README.md

readers/timescale/doc.go

readers/timescale/messages.go

Signed-off-by: corp0529 <[email protected]>

consumers/writers/timescale/init.go

readers/timescale/init.go

consumers/writers/timescale/README.md

consumers/writers/timescale/init.go

Signed-off-by: corp0529 <[email protected]>

cmd/timescale-writer/main.go

cmd/timescale-reader/main.go

consumers/writers/timescale/init.go

readers/timescale/init.go

dborovcanin · 2022-01-17T11:35:57Z

@corp0529 Please resolve all the comments and update the branch. Once you do it, we'll do one more review and it's ready for merge.

Signed-off-by: corp0529 <[email protected]>

drasko

LGTM

consumers/writers/timescale/consumer.go

dborovcanin

After one minor remark is resolved, I'll approve. Great job, @corp0529! Thanks a lot for this contribution.

consumers/writers/timescale/consumer.go

Signed-off-by: corp0529 <[email protected]>

…o MF-1478

Signed-off-by: corp0529 <[email protected]>

manuio

LGTM Thank you!

* MF-1478 - TimescaleDb Reader/Writer Add-on Signed-off-by: John Cleasby <[email protected]> * pull request 1542 change requests Signed-off-by: corp0529 <[email protected]> * pull request 1542 change requests 2 Signed-off-by: corp0529 <[email protected]> * removed unused separator const from timescale reader and writer cmd Signed-off-by: corp0529 <[email protected]> * Fixed naming of timescaleRepo instance Signed-off-by: corp0529 <[email protected]> * Fixed indentation and renamed repo to tr Signed-off-by: corp0529 <[email protected]> Signed-off-by: skovacevic <[email protected]>

corp0529 requested a review from a team as a code owner January 11, 2022 17:33

corp0529 force-pushed the MF-1478 branch from 64b16fe to 0b6659f Compare January 11, 2022 18:03

drasko requested review from arvindh123, blokovi, dborovcanin, manuio, mteodor and nmarcetic January 11, 2022 20:18

MF-1478 - TimescaleDb Reader/Writer Add-on

7e0e25b

Signed-off-by: John Cleasby <[email protected]>

corp0529 force-pushed the MF-1478 branch from 0b6659f to 7e0e25b Compare January 11, 2022 20:38

manuio suggested changes Jan 12, 2022

View reviewed changes

pull request 1542 change requests

2c74e10

Signed-off-by: corp0529 <[email protected]>

corp0529 force-pushed the MF-1478 branch from 185398a to 2c74e10 Compare January 12, 2022 14:11

corp0529 requested a review from manuio January 12, 2022 14:27

dborovcanin changed the title ~~MF-1478 - TimescaleDb Reader/Writer Add-on~~ MF-1478 - TimescaleDB writer and reader add-on Jan 13, 2022

dborovcanin requested changes Jan 13, 2022

View reviewed changes

consumers/writers/timescale/init.go Outdated Show resolved Hide resolved

readers/timescale/init.go Outdated Show resolved Hide resolved

consumers/writers/timescale/README.md Outdated Show resolved Hide resolved

consumers/writers/timescale/init.go Outdated Show resolved Hide resolved

pull request 1542 change requests 2

451a6d3

Signed-off-by: corp0529 <[email protected]>

corp0529 force-pushed the MF-1478 branch from d7d493c to 451a6d3 Compare January 14, 2022 16:04

drasko requested changes Jan 14, 2022

View reviewed changes

cmd/timescale-writer/main.go Outdated Show resolved Hide resolved

cmd/timescale-reader/main.go Outdated Show resolved Hide resolved

consumers/writers/timescale/init.go Show resolved Hide resolved

readers/timescale/init.go Show resolved Hide resolved

corp0529 added 2 commits January 17, 2022 16:36

removed unused separator const from timescale reader and writer cmd

c981cb6

Signed-off-by: corp0529 <[email protected]>

Merge branch 'master' into MF-1478

25f6d77

drasko previously approved these changes Jan 17, 2022

View reviewed changes

manuio suggested changes Jan 18, 2022

View reviewed changes

consumers/writers/timescale/consumer.go Outdated Show resolved Hide resolved

dborovcanin requested changes Jan 18, 2022

View reviewed changes

consumers/writers/timescale/consumer.go Outdated Show resolved Hide resolved

corp0529 added 2 commits January 18, 2022 09:34

Fixed naming of timescaleRepo instance

09a2153

Signed-off-by: corp0529 <[email protected]>

Merge branch 'MF-1478' of https://github.com/jangala-dev/mainflux int…

62f1ccd

…o MF-1478

corp0529 dismissed drasko’s stale review via 62f1ccd January 18, 2022 09:38

dborovcanin previously approved these changes Jan 18, 2022

View reviewed changes

Fixed indentation and renamed repo to tr

f0573e1

Signed-off-by: corp0529 <[email protected]>

corp0529 dismissed dborovcanin’s stale review via f0573e1 January 18, 2022 10:32

manuio approved these changes Jan 18, 2022

View reviewed changes

dborovcanin approved these changes Jan 18, 2022

View reviewed changes

dborovcanin merged commit 864ad14 into absmach:master Jan 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MF-1478 - TimescaleDB writer and reader add-on #1542

MF-1478 - TimescaleDB writer and reader add-on #1542

corp0529 commented Jan 11, 2022 •

edited by manuio

Loading

manuio commented Jan 11, 2022 •

edited

Loading

drasko commented Jan 11, 2022

corp0529 commented Jan 11, 2022

codecov-commenter commented Jan 11, 2022 •

edited

Loading

corp0529 commented Jan 11, 2022

drasko commented Jan 11, 2022

corp0529 commented Jan 11, 2022

manuio commented Jan 12, 2022 •

edited

Loading

dborovcanin commented Jan 17, 2022

drasko left a comment

dborovcanin left a comment •

edited

Loading

manuio left a comment •

edited

Loading

MF-1478 - TimescaleDB writer and reader add-on #1542

MF-1478 - TimescaleDB writer and reader add-on #1542

Conversation

corp0529 commented Jan 11, 2022 • edited by manuio Loading

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified functionality?

manuio commented Jan 11, 2022 • edited Loading

drasko commented Jan 11, 2022

corp0529 commented Jan 11, 2022

codecov-commenter commented Jan 11, 2022 • edited Loading

Codecov Report

corp0529 commented Jan 11, 2022

drasko commented Jan 11, 2022

corp0529 commented Jan 11, 2022

manuio commented Jan 12, 2022 • edited Loading

dborovcanin commented Jan 17, 2022

drasko left a comment

Choose a reason for hiding this comment

dborovcanin left a comment • edited Loading

Choose a reason for hiding this comment

manuio left a comment • edited Loading

Choose a reason for hiding this comment

corp0529 commented Jan 11, 2022 •

edited by manuio

Loading

manuio commented Jan 11, 2022 •

edited

Loading

codecov-commenter commented Jan 11, 2022 •

edited

Loading

manuio commented Jan 12, 2022 •

edited

Loading

dborovcanin left a comment •

edited

Loading

manuio left a comment •

edited

Loading