NOISSUE - Remove debugging message from response of handle error function #696
Conversation
| @@ -25,4 +25,4 @@ handle error = | |||
| "Bad status: " ++ String.fromInt code | |||
|
|
|||
| Http.BadBody err -> | |||
| err | |||
| "Invalid response body" | |||
There was a problem hiding this comment.
Is the error however printed in a browser console, so we can debug problems?
There was a problem hiding this comment.
No, but that's a good idea so I print it in console in new commit 4a5f929
Because you can't have any side-effects in Elm you will see that I have to do a bit of a trick for logging values that I don't want to return.
There was a problem hiding this comment.
We'll need to have some kind of better developed failure reporting mechanism to user. For now, user can inspect browser console and MF console messages. LGTM
Signed-off-by: Ivan Milošević <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
======================================
Coverage 86.3% 86.3%
======================================
Files 62 62
Lines 3723 3723
======================================
Hits 3213 3213
Misses 353 353
Partials 157 157Continue to review full report at Codecov.
|
Signed-off-by: Ivan Milošević <[email protected]>
…tion (absmach#696) * Remove debugging message from response of handle error function Signed-off-by: Ivan Milošević <[email protected]> * Print error in debug console in case of bad body HTTP response Signed-off-by: Ivan Milošević <[email protected]>
…tion (absmach#696) * Remove debugging message from response of handle error function Signed-off-by: Ivan Milošević <[email protected]> * Print error in debug console in case of bad body HTTP response Signed-off-by: Ivan Milošević <[email protected]>
…tion (#696) * Remove debugging message from response of handle error function Signed-off-by: Ivan Milošević <[email protected]> * Print error in debug console in case of bad body HTTP response Signed-off-by: Ivan Milošević <[email protected]>
Signed-off-by: Ivan Milošević [email protected]
What does this do?
Remove debugging message that explains what went wrong with JSON decoder from response of handle error function. Mainflux version on dashboard display that response, so it's swiched to nice error message instead of huge debug.
Which issue(s) does this PR fix/relate to?
No issue