NOISSUE - Add performance improvement to writer filtering #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarcetic
previously approved these changes
May 14, 2019
anovakovic01
dismissed stale reviews from manuio, nmarcetic, and drasko
via
7de7aec
anovakovic01
force-pushed
the
NOISSUE-optimize-writers
branch
from
0113ae5 to
7de7aec
Compare
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 85.33% 85.28% -0.05%
==========================================
Files 66 66
Lines 4228 4228
==========================================
- Hits 3608 3606 -2
- Misses 416 418 +2
Partials 204 204
Continue to review full report at Codecov.
|
anovakovic01
force-pushed
the
NOISSUE-optimize-writers
branch
from
7de7aec to
2e4ccf4
Compare
Signed-off-by: Aleksandar Novakovic <[email protected]>
anovakovic01
force-pushed
the
NOISSUE-optimize-writers
branch
from
2e4ccf4 to
1af5850
Compare
darkodraskovic
approved these changes
May 16, 2019
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
Signed-off-by: Aleksandar Novakovic <[email protected]>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Aleksandar Novakovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Improves writer filtering performance by replacing a list with a set.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.