Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update nginx version #748

Merged
merged 3 commits into from
May 16, 2019

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

This pull request updates version of Nginx image.
It also updates authorization.js file adding some check if values are undefined.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

No. I've deployed it locally and tested Docker composition.

Did you document any new/modified functionality?

No.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 9d30006 into absmach:master May 16, 2019
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dborovcanin dborovcanin deleted the update/nginx-version branch May 16, 2019 10:00
rugwirobaker pushed a commit to rugwirobaker/mainflux that referenced this pull request Jun 26, 2019
* Update version of the Nginx image

Signed-off-by: Dušan Borovčanin <[email protected]>

* Add undefined check for HTTP and WS

Signed-off-by: Dušan Borovčanin <[email protected]>
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Update version of the Nginx image

Signed-off-by: Dušan Borovčanin <[email protected]>

* Add undefined check for HTTP and WS

Signed-off-by: Dušan Borovčanin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants