NOISSUE - Add searchable Things name #750

manuio · 2019-05-17T13:57:06Z

Signed-off-by: Manuel Imperiale [email protected]

Signed-off-by: Manuel Imperiale <[email protected]>

…o things-name

drasko · 2019-05-17T18:16:43Z

bootstrap/mocks/things.go

@@ -166,7 +166,7 @@ func (svc *mainfluxThings) UpdateKey(string, string, string) error {
 	panic("not implemented")
 }

-func (svc *mainfluxThings) ListThings(string, uint64, uint64) (things.ThingsPage, error) {
+func (svc *mainfluxThings) ListThings(string, uint64, uint64, string) (things.ThingsPage, error) {


Consider using variadic functions so that we do not have to pass this param every time.

I am not saying it is better, just analyze this possibility.

@anovakovic01 @dusanb94 @nmarcetic comments?

Instead of using variadic functions and checking the variables like:

package main import ( "fmt" "reflect" ) func test(a ...interface{}) { for i, param := range a { fmt.Printf("%d : %s\n", i, reflect.TypeOf(param)) } } func main() { test(1, "my_way", true) }

It might be better if we use some dependency injection framework like wire (blog post) or one from awesome-go's di list. I've used DI in other languages, but not in Go and I can not say which framework is better.

I think that name can be left as is for now. But if we add any other parameters, we can add query struct and pass it as a parameter to this function.

I agree with @anovakovic01

codecov-io · 2019-05-21T10:43:39Z

Codecov Report

Merging #750 into master will decrease coverage by 1.21%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   86.16%   84.94%   -1.22%     
==========================================
  Files          69       69              
  Lines        4675     4449     -226     
==========================================
- Hits         4028     3779     -249     
- Misses        430      443      +13     
- Partials      217      227      +10

Impacted Files	Coverage Δ
sdk/go/sdk.go	`96.15% <ø> (ø)`	⬆️
things/things.go	`100% <ø> (ø)`	⬆️
things/api/http/endpoint.go	`98.23% <100%> (ø)`	⬆️
things/service.go	`88.75% <100%> (ø)`	⬆️
things/redis/streams.go	`91.93% <100%> (ø)`	⬆️
things/postgres/init.go	`91.48% <100%> (ø)`	⬆️
sdk/go/things.go	`66.3% <100%> (ø)`	⬆️
things/postgres/channels.go	`79.05% <100%> (-6.55%)`	⬇️
things/api/http/requests.go	`77.41% <40%> (-14.63%)`	⬇️
things/api/http/transport.go	`96.55% <63.63%> (-2.43%)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac1e35...9544b95. Read the comment docs.

anovakovic01 · 2019-05-21T17:57:37Z

bootstrap/mocks/things.go

@@ -166,7 +166,7 @@ func (svc *mainfluxThings) UpdateKey(string, string, string) error {
 	panic("not implemented")
 }

-func (svc *mainfluxThings) ListThings(string, uint64, uint64) (things.ThingsPage, error) {
+func (svc *mainfluxThings) ListThings(string, uint64, uint64, string) (things.ThingsPage, error) {


I think that name can be left as is for now. But if we add any other parameters, we can add query struct and pass it as a parameter to this function.

anovakovic01 · 2019-05-21T18:06:55Z

things/api/http/requests.go

 }

 func (req *listResourcesReq) validate() error {
 	if req.token == "" {
 		return things.ErrUnauthorizedAccess
 	}

-	if req.limit == 0 || req.limit > maxLimitSize {
+	if req.limit == 0 || req.limit > maxLimitSize ||
+		len(req.name) > maxNameSize {


Please move the name part to a separate if statement in order to keep it simple.

Yes pls, we are avoiding chaining as much as we can.

anovakovic01 · 2019-05-21T18:12:43Z

things/api/logging.go

@@ -81,7 +81,7 @@ func (lm *loggingMiddleware) ViewThing(token, id string) (thing things.Thing, er
 	return lm.svc.ViewThing(token, id)
 }

-func (lm *loggingMiddleware) ListThings(token string, offset, limit uint64) (_ things.ThingsPage, err error) {
+func (lm *loggingMiddleware) ListThings(token string, offset, limit uint64, name string) (_ things.ThingsPage, err error) {
 	defer func(begin time.Time) {
 		message := fmt.Sprintf("Method list_things for token %s took %s to complete", token, time.Since(begin))


Think about adding name to log msg.

anovakovic01 · 2019-05-21T18:13:53Z

things/postgres/things.go

+	nq := ""
+	if name != "" {
+		name = fmt.Sprintf(`%%%s%%`, name)
+		nq = fmt.Sprintf(`AND name LIKE :name`)


No need to use this second fmt.Sprintf.

anovakovic01 · 2019-05-21T18:16:08Z

things/postgres/things_test.go

 			Key:   thkey,
 		}

-		thingRepo.Save(t)
+		// Create one thing with name
+		if i == 1 {


Why not using 0 here?

anovakovic01 · 2019-05-21T18:17:36Z

things/postgres/things_test.go

+			name:   name,
+			size:   1,
+		},
+		"retrieve things with invalid name": {


This is not an invalid name. There are no things with this name. Think about adding an invalid name use case (with a name which length is larger than the limit that you've set).

anovakovic01 · 2019-05-21T18:19:37Z

things/redis/streams_test.go

-	esths, eserr := essvc.ListThings(token, 0, 10)
-	ths, err := svc.ListThings(token, 0, 10)
+	esths, eserr := essvc.ListThings(token, 0, 10, "")
+	ths, err := svc.ListThings(token, 0, 10, "lora")


Can use change this to something else. It's not a huge deal, but I don't like having anything protocol specific even in tests.

Good catch, I forgot this one

anovakovic01 · 2019-05-21T18:22:35Z

things/api/http/requests.go

+	if len(req.Name) > maxNameSize {
+		return things.ErrMalformedEntity
+	}
+


If we're going to introduce this limit, you should add it to DB schema too (use varchar(64)). Also, not sure if 64 is large enough. I would put at least 128. @drasko @nmarcetic @dusanb94 @srados what do you think?

I agree! Especially with about size 64 not sounds to much.

Signed-off-by: Manuel Imperiale <[email protected]>

anovakovic01

LGTM!

anovakovic01

LGTM!

Signed-off-by: Manuel Imperiale <[email protected]>

…into things-name

anovakovic01

LGTM!

Signed-off-by: Manuel Imperiale <[email protected]>

anovakovic01

LGTM!

* NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Typo fix Signed-off-by: Manuel Imperiale <[email protected]> * Rm requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Add name in ListThings loggins Signed-off-by: Manuel Imperiale <[email protected]> * Add invalidName var for tests Signed-off-by: Manuel Imperiale <[email protected]> * Set maxNameSize to 1024 Signed-off-by: Manuel Imperiale <[email protected]> * Fix postgres test Signed-off-by: Manuel Imperiale <[email protected]> * Fix total when filtering things by name Signed-off-by: Manuel Imperiale <[email protected]> * Fix review Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]>

* MF-722 - Change UUID lib (#746) * Update uuid package and update things serivce Signed-off-by: Aleksandar Novakovic <[email protected]> * Update bootstrap service tests Signed-off-by: Aleksandar Novakovic <[email protected]> * Update existing postgres writer tests Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-732 - Add Postgres reader (#740) * NOISSUE - Fix Readers logs Signed-off-by: Manuel Imperiale <[email protected]> * MF-732 - Add Postgres reader Signed-off-by: Manuel Imperiale <[email protected]> * Fix total count Signed-off-by: Manuel Imperiale <[email protected]> * Rm commented code Signed-off-by: Manuel Imperiale <[email protected]> * Add Postgres reader tests Signed-off-by: Manuel Imperiale <[email protected]> * Fix editor format Signed-off-by: Manuel Imperiale <[email protected]> * Change UUID lib Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-742 - Things to support single user scenario (#749) * Add single user mode to things service Signed-off-by: Aleksandar Novakovic <[email protected]> * Add tests for things/users package Signed-off-by: Aleksandar Novakovic <[email protected]> * Update init order in main Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * Update grpc and protobuf deps in mqtt adapter (#751) Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * Fix MQTT raw message deserialization (#753) Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add certificate fields to the Bootstrap service (#752) * Add cert fields to the BS Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert fields when creating a config Signed-off-by: Dušan Borovčanin <[email protected]> * Add update cert endpoint Signed-off-by: Dušan Borovčanin <[email protected]> * Fix key column name Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert fields to db converters Signed-off-by: Dušan Borovčanin <[email protected]> * Secure cert update endpoint Signed-off-by: Dušan Borovčanin <[email protected]> * Authroize cert update methods Signed-off-by: Dušan Borovčanin <[email protected]> * Fix Bootstrap service tests Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert update service tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update endpoit tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update API docs Signed-off-by: Dušan Borovčanin <[email protected]> * Update request tests Signed-off-by: Dušan Borovčanin <[email protected]> * Fix request tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update repository tests Signed-off-by: Dušan Borovčanin <[email protected]> * Fix typo in repo tests Signed-off-by: Dušan Borovčanin <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add searchable Things name (#750) * NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Typo fix Signed-off-by: Manuel Imperiale <[email protected]> * Rm requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Add name in ListThings loggins Signed-off-by: Manuel Imperiale <[email protected]> * Add invalidName var for tests Signed-off-by: Manuel Imperiale <[email protected]> * Set maxNameSize to 1024 Signed-off-by: Manuel Imperiale <[email protected]> * Fix postgres test Signed-off-by: Manuel Imperiale <[email protected]> * Fix total when filtering things by name Signed-off-by: Manuel Imperiale <[email protected]> * Fix review Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * Add missing Websocket.js into docker ui image (#755) Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-466 - ARM docker deployment (#756) * Add arm Dockerfiles Change version of postgres images in docker-compose to use versions with multiarch Signed-off-by: Ivan Milošević <[email protected]> * docker compose file Signed-off-by: Ivan Milošević <[email protected]> * remove bin qemu file Signed-off-by: Ivan Milošević <[email protected]> * remove unnecesarry comments Signed-off-by: Ivan Milošević <[email protected]> * Add make dockers_arm32v7 in Makefile Signed-off-by: Ivan Milošević <[email protected]> * Remove docker/Dockerfile.arm Signed-off-by: Ivan Milošević <[email protected]> * Add build for arm32v7 in ui Makefile Signed-off-by: Ivan Milošević <[email protected]> * Add arm32v7 tags Signed-off-by: Ivan Milošević <[email protected]> * add docker-compose for arm remove thing-db in docker compose (use same db as user) fix dockerfile and makefile Signed-off-by: Ivan Milošević <[email protected]> * fix thing database env variable Signed-off-by: Ivan Milošević <[email protected]> * Switch back to separate database for things and users Signed-off-by: Ivan Milošević <[email protected]> * rename arm32v7 to arm Signed-off-by: Ivan Milošević <[email protected]> * remove arm32v7 tag rename arm32v7 image names Signed-off-by: Ivan Milošević <[email protected]> * Rename command for making mqtt and ui individual images, to match other miscroservices Signed-off-by: Ivan Milošević <[email protected]> * Push arm docker images Signed-off-by: Ivan Milošević <[email protected]> * fix fucntion call in ci.sh Signed-off-by: Ivan Milošević <[email protected]> * mergiing ui/Dockerfile Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add searchable Channels name (#754) * NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * NOISSUE - Add searchable Channels name Signed-off-by: Manuel Imperiale <[email protected]> * Fix test description Signed-off-by: Manuel Imperiale <[email protected]> * Fix bootstrap mocks Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Remove installing non-existent package in ci (#758) * Remove installing non-existent package from ci Signed-off-by: Ivan Milošević <[email protected]> * remove branch master condition in ci.sh to test it Signed-off-by: Ivan Milošević <[email protected]> * fix syntax error Signed-off-by: Ivan Milošević <[email protected]> * update apt Signed-off-by: Ivan Milošević <[email protected]> * build arm images for latest release push ui and mqtt arm images install only qemu-user-static Signed-off-by: Ivan Milošević <[email protected]> * clean docker after pushing amd64 images Signed-off-by: Ivan Milošević <[email protected]> * installing all qemu app Signed-off-by: Ivan Milošević <[email protected]> * remove docker images before building ui and mqtt arm-images Signed-off-by: Ivan Milošević <[email protected]> * prune dockers and test only arm build Signed-off-by: Ivan Milošević <[email protected]> * fix syntax error Signed-off-by: Ivan Milošević <[email protected]> * fix moving qemu-arm-static Signed-off-by: Ivan Milošević <[email protected]> * installing qemu with apt-get Signed-off-by: Ivan Milošević <[email protected]> * add another apt-get update Signed-off-by: Ivan Milošević <[email protected]> * apt install one liner Signed-off-by: Ivan Milošević <[email protected]> * testing ci script Signed-off-by: Ivan Milošević <[email protected]> * After installing qemu, get appropriate version Signed-off-by: Ivan Milošević <[email protected]> * Test ci without amd64 dockers Signed-off-by: Ivan Milošević <[email protected]> * remove tests from ci for test purpose Signed-off-by: Ivan Milošević <[email protected]> * Uncomment commands Signed-off-by: Ivan Milošević <[email protected]> * Remove whitespace and change order of building images Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * nginx Signed-off-by: mteodor <[email protected]> * change to openresty Signed-off-by: mteodor <[email protected]> * change to openresty and accept env from docker compose Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * NOISSUE - Fix Docker for ARM (#760) * NOISSUE - Fix Docker for ARM Signed-off-by: drasko <[email protected]> * Correct ARGs Signed-off-by: drasko <[email protected]> * Fix docker-compose for ARM Signed-off-by: drasko <[email protected]> * Add docker manifest Signed-off-by: drasko <[email protected]> * cp not mv qemu from mf root Signed-off-by: Ivan Milošević <[email protected]> * fix amd64 docker names for ui and mqtt images Signed-off-by: Ivan Milošević <[email protected]> * edit ci.sh for testing purposes Signed-off-by: Ivan Milošević <[email protected]> * remove bachslash from make manifest edits in ci for testing purposes Signed-off-by: Ivan Milošević <[email protected]> * fix manifest call Signed-off-by: Ivan Milošević <[email protected]> * add manifest on version realese delete space before latest argument fix for loop in manifest creation Signed-off-by: Ivan Milošević <[email protected]> * include tests Signed-off-by: Ivan Milošević <[email protected]> * docker system prune remove tests for testin purposes Signed-off-by: Ivan Milošević <[email protected]> * Add variant in manifest file for armv7 Signed-off-by: Ivan Milošević <[email protected]> * Remove white space Signed-off-by: Ivan Milošević <[email protected]> * paralelise the compilation Signed-off-by: Ivan Milošević <[email protected]> * fix place of -j$NPROC Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * adding env variable Signed-off-by: mteodor <[email protected]> * fix variant option for manifest annotate (#765) Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * use docker env to set port Signed-off-by: mteodor <[email protected]> * add env to conf port in nginx.conf Signed-off-by: mteodor <[email protected]> * replace string with docker env Signed-off-by: mteodor <[email protected]> * replace string with docker env Signed-off-by: mteodor <[email protected]> * Update docs (#766) Signed-off-by: Dušan Borovčanin <[email protected]> Signed-off-by: mteodor <[email protected]> * remove not needed comment Signed-off-by: mteodor <[email protected]> * adding .env file for default UI_PORT - if no enviroment UI_PORT is set value from .env file is used Signed-off-by: mteodor <[email protected]> * get default UI_PORT variable value from .env file Signed-off-by: mteodor <[email protected]> * set default port value to 3000 Signed-off-by: mteodor <[email protected]>

* NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Typo fix Signed-off-by: Manuel Imperiale <[email protected]> * Rm requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Add name in ListThings loggins Signed-off-by: Manuel Imperiale <[email protected]> * Add invalidName var for tests Signed-off-by: Manuel Imperiale <[email protected]> * Set maxNameSize to 1024 Signed-off-by: Manuel Imperiale <[email protected]> * Fix postgres test Signed-off-by: Manuel Imperiale <[email protected]> * Fix total when filtering things by name Signed-off-by: Manuel Imperiale <[email protected]> * Fix review Signed-off-by: Manuel Imperiale <[email protected]>

* MF-722 - Change UUID lib (absmach#746) * Update uuid package and update things serivce Signed-off-by: Aleksandar Novakovic <[email protected]> * Update bootstrap service tests Signed-off-by: Aleksandar Novakovic <[email protected]> * Update existing postgres writer tests Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-732 - Add Postgres reader (absmach#740) * NOISSUE - Fix Readers logs Signed-off-by: Manuel Imperiale <[email protected]> * MF-732 - Add Postgres reader Signed-off-by: Manuel Imperiale <[email protected]> * Fix total count Signed-off-by: Manuel Imperiale <[email protected]> * Rm commented code Signed-off-by: Manuel Imperiale <[email protected]> * Add Postgres reader tests Signed-off-by: Manuel Imperiale <[email protected]> * Fix editor format Signed-off-by: Manuel Imperiale <[email protected]> * Change UUID lib Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-742 - Things to support single user scenario (absmach#749) * Add single user mode to things service Signed-off-by: Aleksandar Novakovic <[email protected]> * Add tests for things/users package Signed-off-by: Aleksandar Novakovic <[email protected]> * Update init order in main Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * Update grpc and protobuf deps in mqtt adapter (absmach#751) Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * Fix MQTT raw message deserialization (absmach#753) Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add certificate fields to the Bootstrap service (absmach#752) * Add cert fields to the BS Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert fields when creating a config Signed-off-by: Dušan Borovčanin <[email protected]> * Add update cert endpoint Signed-off-by: Dušan Borovčanin <[email protected]> * Fix key column name Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert fields to db converters Signed-off-by: Dušan Borovčanin <[email protected]> * Secure cert update endpoint Signed-off-by: Dušan Borovčanin <[email protected]> * Authroize cert update methods Signed-off-by: Dušan Borovčanin <[email protected]> * Fix Bootstrap service tests Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert update service tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update endpoit tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update API docs Signed-off-by: Dušan Borovčanin <[email protected]> * Update request tests Signed-off-by: Dušan Borovčanin <[email protected]> * Fix request tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update repository tests Signed-off-by: Dušan Borovčanin <[email protected]> * Fix typo in repo tests Signed-off-by: Dušan Borovčanin <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add searchable Things name (absmach#750) * NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Typo fix Signed-off-by: Manuel Imperiale <[email protected]> * Rm requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Add name in ListThings loggins Signed-off-by: Manuel Imperiale <[email protected]> * Add invalidName var for tests Signed-off-by: Manuel Imperiale <[email protected]> * Set maxNameSize to 1024 Signed-off-by: Manuel Imperiale <[email protected]> * Fix postgres test Signed-off-by: Manuel Imperiale <[email protected]> * Fix total when filtering things by name Signed-off-by: Manuel Imperiale <[email protected]> * Fix review Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * Add missing Websocket.js into docker ui image (absmach#755) Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-466 - ARM docker deployment (absmach#756) * Add arm Dockerfiles Change version of postgres images in docker-compose to use versions with multiarch Signed-off-by: Ivan Milošević <[email protected]> * docker compose file Signed-off-by: Ivan Milošević <[email protected]> * remove bin qemu file Signed-off-by: Ivan Milošević <[email protected]> * remove unnecesarry comments Signed-off-by: Ivan Milošević <[email protected]> * Add make dockers_arm32v7 in Makefile Signed-off-by: Ivan Milošević <[email protected]> * Remove docker/Dockerfile.arm Signed-off-by: Ivan Milošević <[email protected]> * Add build for arm32v7 in ui Makefile Signed-off-by: Ivan Milošević <[email protected]> * Add arm32v7 tags Signed-off-by: Ivan Milošević <[email protected]> * add docker-compose for arm remove thing-db in docker compose (use same db as user) fix dockerfile and makefile Signed-off-by: Ivan Milošević <[email protected]> * fix thing database env variable Signed-off-by: Ivan Milošević <[email protected]> * Switch back to separate database for things and users Signed-off-by: Ivan Milošević <[email protected]> * rename arm32v7 to arm Signed-off-by: Ivan Milošević <[email protected]> * remove arm32v7 tag rename arm32v7 image names Signed-off-by: Ivan Milošević <[email protected]> * Rename command for making mqtt and ui individual images, to match other miscroservices Signed-off-by: Ivan Milošević <[email protected]> * Push arm docker images Signed-off-by: Ivan Milošević <[email protected]> * fix fucntion call in ci.sh Signed-off-by: Ivan Milošević <[email protected]> * mergiing ui/Dockerfile Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add searchable Channels name (absmach#754) * NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * NOISSUE - Add searchable Channels name Signed-off-by: Manuel Imperiale <[email protected]> * Fix test description Signed-off-by: Manuel Imperiale <[email protected]> * Fix bootstrap mocks Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Remove installing non-existent package in ci (absmach#758) * Remove installing non-existent package from ci Signed-off-by: Ivan Milošević <[email protected]> * remove branch master condition in ci.sh to test it Signed-off-by: Ivan Milošević <[email protected]> * fix syntax error Signed-off-by: Ivan Milošević <[email protected]> * update apt Signed-off-by: Ivan Milošević <[email protected]> * build arm images for latest release push ui and mqtt arm images install only qemu-user-static Signed-off-by: Ivan Milošević <[email protected]> * clean docker after pushing amd64 images Signed-off-by: Ivan Milošević <[email protected]> * installing all qemu app Signed-off-by: Ivan Milošević <[email protected]> * remove docker images before building ui and mqtt arm-images Signed-off-by: Ivan Milošević <[email protected]> * prune dockers and test only arm build Signed-off-by: Ivan Milošević <[email protected]> * fix syntax error Signed-off-by: Ivan Milošević <[email protected]> * fix moving qemu-arm-static Signed-off-by: Ivan Milošević <[email protected]> * installing qemu with apt-get Signed-off-by: Ivan Milošević <[email protected]> * add another apt-get update Signed-off-by: Ivan Milošević <[email protected]> * apt install one liner Signed-off-by: Ivan Milošević <[email protected]> * testing ci script Signed-off-by: Ivan Milošević <[email protected]> * After installing qemu, get appropriate version Signed-off-by: Ivan Milošević <[email protected]> * Test ci without amd64 dockers Signed-off-by: Ivan Milošević <[email protected]> * remove tests from ci for test purpose Signed-off-by: Ivan Milošević <[email protected]> * Uncomment commands Signed-off-by: Ivan Milošević <[email protected]> * Remove whitespace and change order of building images Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * nginx Signed-off-by: mteodor <[email protected]> * change to openresty Signed-off-by: mteodor <[email protected]> * change to openresty and accept env from docker compose Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * NOISSUE - Fix Docker for ARM (absmach#760) * NOISSUE - Fix Docker for ARM Signed-off-by: drasko <[email protected]> * Correct ARGs Signed-off-by: drasko <[email protected]> * Fix docker-compose for ARM Signed-off-by: drasko <[email protected]> * Add docker manifest Signed-off-by: drasko <[email protected]> * cp not mv qemu from mf root Signed-off-by: Ivan Milošević <[email protected]> * fix amd64 docker names for ui and mqtt images Signed-off-by: Ivan Milošević <[email protected]> * edit ci.sh for testing purposes Signed-off-by: Ivan Milošević <[email protected]> * remove bachslash from make manifest edits in ci for testing purposes Signed-off-by: Ivan Milošević <[email protected]> * fix manifest call Signed-off-by: Ivan Milošević <[email protected]> * add manifest on version realese delete space before latest argument fix for loop in manifest creation Signed-off-by: Ivan Milošević <[email protected]> * include tests Signed-off-by: Ivan Milošević <[email protected]> * docker system prune remove tests for testin purposes Signed-off-by: Ivan Milošević <[email protected]> * Add variant in manifest file for armv7 Signed-off-by: Ivan Milošević <[email protected]> * Remove white space Signed-off-by: Ivan Milošević <[email protected]> * paralelise the compilation Signed-off-by: Ivan Milošević <[email protected]> * fix place of -j$NPROC Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * adding env variable Signed-off-by: mteodor <[email protected]> * fix variant option for manifest annotate (absmach#765) Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * use docker env to set port Signed-off-by: mteodor <[email protected]> * add env to conf port in nginx.conf Signed-off-by: mteodor <[email protected]> * replace string with docker env Signed-off-by: mteodor <[email protected]> * replace string with docker env Signed-off-by: mteodor <[email protected]> * Update docs (absmach#766) Signed-off-by: Dušan Borovčanin <[email protected]> Signed-off-by: mteodor <[email protected]> * remove not needed comment Signed-off-by: mteodor <[email protected]> * adding .env file for default UI_PORT - if no enviroment UI_PORT is set value from .env file is used Signed-off-by: mteodor <[email protected]> * get default UI_PORT variable value from .env file Signed-off-by: mteodor <[email protected]> * set default port value to 3000 Signed-off-by: mteodor <[email protected]>

* NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Typo fix Signed-off-by: Manuel Imperiale <[email protected]> * Rm requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Add name in ListThings loggins Signed-off-by: Manuel Imperiale <[email protected]> * Add invalidName var for tests Signed-off-by: Manuel Imperiale <[email protected]> * Set maxNameSize to 1024 Signed-off-by: Manuel Imperiale <[email protected]> * Fix postgres test Signed-off-by: Manuel Imperiale <[email protected]> * Fix total when filtering things by name Signed-off-by: Manuel Imperiale <[email protected]> * Fix review Signed-off-by: Manuel Imperiale <[email protected]>

* MF-722 - Change UUID lib (#746) * Update uuid package and update things serivce Signed-off-by: Aleksandar Novakovic <[email protected]> * Update bootstrap service tests Signed-off-by: Aleksandar Novakovic <[email protected]> * Update existing postgres writer tests Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-732 - Add Postgres reader (#740) * NOISSUE - Fix Readers logs Signed-off-by: Manuel Imperiale <[email protected]> * MF-732 - Add Postgres reader Signed-off-by: Manuel Imperiale <[email protected]> * Fix total count Signed-off-by: Manuel Imperiale <[email protected]> * Rm commented code Signed-off-by: Manuel Imperiale <[email protected]> * Add Postgres reader tests Signed-off-by: Manuel Imperiale <[email protected]> * Fix editor format Signed-off-by: Manuel Imperiale <[email protected]> * Change UUID lib Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-742 - Things to support single user scenario (#749) * Add single user mode to things service Signed-off-by: Aleksandar Novakovic <[email protected]> * Add tests for things/users package Signed-off-by: Aleksandar Novakovic <[email protected]> * Update init order in main Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * Update grpc and protobuf deps in mqtt adapter (#751) Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * Fix MQTT raw message deserialization (#753) Signed-off-by: Aleksandar Novakovic <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add certificate fields to the Bootstrap service (#752) * Add cert fields to the BS Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert fields when creating a config Signed-off-by: Dušan Borovčanin <[email protected]> * Add update cert endpoint Signed-off-by: Dušan Borovčanin <[email protected]> * Fix key column name Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert fields to db converters Signed-off-by: Dušan Borovčanin <[email protected]> * Secure cert update endpoint Signed-off-by: Dušan Borovčanin <[email protected]> * Authroize cert update methods Signed-off-by: Dušan Borovčanin <[email protected]> * Fix Bootstrap service tests Signed-off-by: Dušan Borovčanin <[email protected]> * Add cert update service tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update endpoit tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update API docs Signed-off-by: Dušan Borovčanin <[email protected]> * Update request tests Signed-off-by: Dušan Borovčanin <[email protected]> * Fix request tests Signed-off-by: Dušan Borovčanin <[email protected]> * Update repository tests Signed-off-by: Dušan Borovčanin <[email protected]> * Fix typo in repo tests Signed-off-by: Dušan Borovčanin <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add searchable Things name (#750) * NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Typo fix Signed-off-by: Manuel Imperiale <[email protected]> * Rm requests_test Signed-off-by: Manuel Imperiale <[email protected]> * Add name in ListThings loggins Signed-off-by: Manuel Imperiale <[email protected]> * Add invalidName var for tests Signed-off-by: Manuel Imperiale <[email protected]> * Set maxNameSize to 1024 Signed-off-by: Manuel Imperiale <[email protected]> * Fix postgres test Signed-off-by: Manuel Imperiale <[email protected]> * Fix total when filtering things by name Signed-off-by: Manuel Imperiale <[email protected]> * Fix review Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * Add missing Websocket.js into docker ui image (#755) Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * MF-466 - ARM docker deployment (#756) * Add arm Dockerfiles Change version of postgres images in docker-compose to use versions with multiarch Signed-off-by: Ivan Milošević <[email protected]> * docker compose file Signed-off-by: Ivan Milošević <[email protected]> * remove bin qemu file Signed-off-by: Ivan Milošević <[email protected]> * remove unnecesarry comments Signed-off-by: Ivan Milošević <[email protected]> * Add make dockers_arm32v7 in Makefile Signed-off-by: Ivan Milošević <[email protected]> * Remove docker/Dockerfile.arm Signed-off-by: Ivan Milošević <[email protected]> * Add build for arm32v7 in ui Makefile Signed-off-by: Ivan Milošević <[email protected]> * Add arm32v7 tags Signed-off-by: Ivan Milošević <[email protected]> * add docker-compose for arm remove thing-db in docker compose (use same db as user) fix dockerfile and makefile Signed-off-by: Ivan Milošević <[email protected]> * fix thing database env variable Signed-off-by: Ivan Milošević <[email protected]> * Switch back to separate database for things and users Signed-off-by: Ivan Milošević <[email protected]> * rename arm32v7 to arm Signed-off-by: Ivan Milošević <[email protected]> * remove arm32v7 tag rename arm32v7 image names Signed-off-by: Ivan Milošević <[email protected]> * Rename command for making mqtt and ui individual images, to match other miscroservices Signed-off-by: Ivan Milošević <[email protected]> * Push arm docker images Signed-off-by: Ivan Milošević <[email protected]> * fix fucntion call in ci.sh Signed-off-by: Ivan Milošević <[email protected]> * mergiing ui/Dockerfile Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Add searchable Channels name (#754) * NOISSUE - Add searchable Things name Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> * Fix typo Signed-off-by: Manuel Imperiale <[email protected]> * Add postgres schema validation and tests Signed-off-by: Manuel Imperiale <[email protected]> * Add namme tests in requests_test Signed-off-by: Manuel Imperiale <[email protected]> * NOISSUE - Add searchable Channels name Signed-off-by: Manuel Imperiale <[email protected]> * Fix test description Signed-off-by: Manuel Imperiale <[email protected]> * Fix bootstrap mocks Signed-off-by: Manuel Imperiale <[email protected]> * Fix reviews Signed-off-by: Manuel Imperiale <[email protected]> Signed-off-by: mteodor <[email protected]> * NOISSUE - Remove installing non-existent package in ci (#758) * Remove installing non-existent package from ci Signed-off-by: Ivan Milošević <[email protected]> * remove branch master condition in ci.sh to test it Signed-off-by: Ivan Milošević <[email protected]> * fix syntax error Signed-off-by: Ivan Milošević <[email protected]> * update apt Signed-off-by: Ivan Milošević <[email protected]> * build arm images for latest release push ui and mqtt arm images install only qemu-user-static Signed-off-by: Ivan Milošević <[email protected]> * clean docker after pushing amd64 images Signed-off-by: Ivan Milošević <[email protected]> * installing all qemu app Signed-off-by: Ivan Milošević <[email protected]> * remove docker images before building ui and mqtt arm-images Signed-off-by: Ivan Milošević <[email protected]> * prune dockers and test only arm build Signed-off-by: Ivan Milošević <[email protected]> * fix syntax error Signed-off-by: Ivan Milošević <[email protected]> * fix moving qemu-arm-static Signed-off-by: Ivan Milošević <[email protected]> * installing qemu with apt-get Signed-off-by: Ivan Milošević <[email protected]> * add another apt-get update Signed-off-by: Ivan Milošević <[email protected]> * apt install one liner Signed-off-by: Ivan Milošević <[email protected]> * testing ci script Signed-off-by: Ivan Milošević <[email protected]> * After installing qemu, get appropriate version Signed-off-by: Ivan Milošević <[email protected]> * Test ci without amd64 dockers Signed-off-by: Ivan Milošević <[email protected]> * remove tests from ci for test purpose Signed-off-by: Ivan Milošević <[email protected]> * Uncomment commands Signed-off-by: Ivan Milošević <[email protected]> * Remove whitespace and change order of building images Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * nginx Signed-off-by: mteodor <[email protected]> * change to openresty Signed-off-by: mteodor <[email protected]> * change to openresty and accept env from docker compose Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * revert to master Signed-off-by: mteodor <[email protected]> * NOISSUE - Fix Docker for ARM (#760) * NOISSUE - Fix Docker for ARM Signed-off-by: drasko <[email protected]> * Correct ARGs Signed-off-by: drasko <[email protected]> * Fix docker-compose for ARM Signed-off-by: drasko <[email protected]> * Add docker manifest Signed-off-by: drasko <[email protected]> * cp not mv qemu from mf root Signed-off-by: Ivan Milošević <[email protected]> * fix amd64 docker names for ui and mqtt images Signed-off-by: Ivan Milošević <[email protected]> * edit ci.sh for testing purposes Signed-off-by: Ivan Milošević <[email protected]> * remove bachslash from make manifest edits in ci for testing purposes Signed-off-by: Ivan Milošević <[email protected]> * fix manifest call Signed-off-by: Ivan Milošević <[email protected]> * add manifest on version realese delete space before latest argument fix for loop in manifest creation Signed-off-by: Ivan Milošević <[email protected]> * include tests Signed-off-by: Ivan Milošević <[email protected]> * docker system prune remove tests for testin purposes Signed-off-by: Ivan Milošević <[email protected]> * Add variant in manifest file for armv7 Signed-off-by: Ivan Milošević <[email protected]> * Remove white space Signed-off-by: Ivan Milošević <[email protected]> * paralelise the compilation Signed-off-by: Ivan Milošević <[email protected]> * fix place of -j$NPROC Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * adding env variable Signed-off-by: mteodor <[email protected]> * fix variant option for manifest annotate (#765) Signed-off-by: Ivan Milošević <[email protected]> Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * enable port configure from env var in docker-compose Signed-off-by: mteodor <[email protected]> * use docker env to set port Signed-off-by: mteodor <[email protected]> * add env to conf port in nginx.conf Signed-off-by: mteodor <[email protected]> * replace string with docker env Signed-off-by: mteodor <[email protected]> * replace string with docker env Signed-off-by: mteodor <[email protected]> * Update docs (#766) Signed-off-by: Dušan Borovčanin <[email protected]> Signed-off-by: mteodor <[email protected]> * remove not needed comment Signed-off-by: mteodor <[email protected]> * adding .env file for default UI_PORT - if no enviroment UI_PORT is set value from .env file is used Signed-off-by: mteodor <[email protected]> * get default UI_PORT variable value from .env file Signed-off-by: mteodor <[email protected]> * set default port value to 3000 Signed-off-by: mteodor <[email protected]>

manuio added 2 commits May 17, 2019 19:52

NOISSUE - Add searchable Things name

8844151

Signed-off-by: Manuel Imperiale <[email protected]>

Merge branch 'master' of https://www.github.com/mainflux/mainflux int…

d48f9fd

…o things-name

drasko reviewed May 17, 2019

View reviewed changes

Merge branch 'master' into things-name

d93aaf5

anovakovic01 suggested changes May 21, 2019

View reviewed changes

manuio added 5 commits May 22, 2019 15:53

Fix reviews

108487e

Signed-off-by: Manuel Imperiale <[email protected]>

Fix typo

63e96b0

Signed-off-by: Manuel Imperiale <[email protected]>

Add postgres schema validation and tests

90a7048

Signed-off-by: Manuel Imperiale <[email protected]>

Add namme tests in requests_test

48e663c

Signed-off-by: Manuel Imperiale <[email protected]>

Typo fix

5b8e3e2

Signed-off-by: Manuel Imperiale <[email protected]>

anovakovic01 previously approved these changes May 23, 2019

View reviewed changes

Rm requests_test

ce32bf3

Signed-off-by: Manuel Imperiale <[email protected]>

manuio dismissed anovakovic01’s stale review via ce32bf3 May 24, 2019 09:52

manuio added 2 commits May 24, 2019 12:01

Add name in ListThings loggins

f5169eb

Signed-off-by: Manuel Imperiale <[email protected]>

Add invalidName var for tests

32c3e27

Signed-off-by: Manuel Imperiale <[email protected]>

anovakovic01 approved these changes May 24, 2019

View reviewed changes

Merge branch 'master' into things-name

5450824

anovakovic01 previously approved these changes May 24, 2019

View reviewed changes

manuio added 3 commits May 24, 2019 19:52

Set maxNameSize to 1024

8c2128e

Signed-off-by: Manuel Imperiale <[email protected]>

Fix postgres test

ad5f088

Signed-off-by: Manuel Imperiale <[email protected]>

Merge branch 'things-name' of https://www.github.com/manuio/mainflux …

10bea04

…into things-name

manuio dismissed anovakovic01’s stale review via 10bea04 May 24, 2019 21:29

anovakovic01 previously approved these changes May 30, 2019

View reviewed changes

Fix total when filtering things by name

b05dc86

Signed-off-by: Manuel Imperiale <[email protected]>

manuio dismissed anovakovic01’s stale review via b05dc86 May 30, 2019 09:26

Fix review

9544b95

Signed-off-by: Manuel Imperiale <[email protected]>

anovakovic01 approved these changes May 30, 2019

View reviewed changes

nmarcetic approved these changes May 30, 2019

View reviewed changes

manuio merged commit c8979ac into absmach:master May 30, 2019

manuio deleted the things-name branch May 30, 2019 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Add searchable Things name #750

NOISSUE - Add searchable Things name #750

manuio commented May 17, 2019

drasko May 17, 2019

chombium May 18, 2019 •

edited

Loading

anovakovic01 May 21, 2019

manuio May 22, 2019

codecov-io commented May 21, 2019 •

edited

Loading

anovakovic01 May 21, 2019

anovakovic01 May 21, 2019

nmarcetic May 24, 2019

anovakovic01 May 21, 2019

anovakovic01 May 21, 2019

anovakovic01 May 21, 2019

anovakovic01 May 21, 2019

anovakovic01 May 21, 2019

manuio May 22, 2019

anovakovic01 May 21, 2019

nmarcetic May 24, 2019

anovakovic01 left a comment

anovakovic01 left a comment

anovakovic01 left a comment

anovakovic01 left a comment

NOISSUE - Add searchable Things name #750

NOISSUE - Add searchable Things name #750

Conversation

manuio commented May 17, 2019

Choose a reason for hiding this comment

chombium May 18, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented May 21, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anovakovic01 left a comment

Choose a reason for hiding this comment

anovakovic01 left a comment

Choose a reason for hiding this comment

anovakovic01 left a comment

Choose a reason for hiding this comment

anovakovic01 left a comment

Choose a reason for hiding this comment

chombium May 18, 2019 •

edited

Loading

codecov-io commented May 21, 2019 •

edited

Loading