Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update Protobuf version #902

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

This pull request updates Protobuf compiler, Protobuf gRPC plugin, and other Protobuf-related code, as well as corresponding CI script.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

The existing tests must pass.

Did you document any new/modified functionality?

No, but the doc section with the required versions for the tools we use will be added soon.

@dborovcanin dborovcanin requested a review from a team as a code owner October 22, 2019 16:18
@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e16a025). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #902   +/-   ##
=========================================
  Coverage          ?   83.67%           
=========================================
  Files             ?       75           
  Lines             ?     5083           
  Branches          ?        0           
=========================================
  Hits              ?     4253           
  Misses            ?      582           
  Partials          ?      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16a025...9863394. Read the comment docs.

Signed-off-by: Dušan Borovčanin <[email protected]>
Signed-off-by: Dušan Borovčanin <[email protected]>
@dborovcanin dborovcanin force-pushed the update/protoc-version branch from 6191bf7 to 9863394 Compare October 22, 2019 16:36
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit cdf9347 into absmach:master Oct 22, 2019
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Update Protobuf version

Signed-off-by: Dušan Borovčanin <[email protected]>

* Update gRPC version

Signed-off-by: Dušan Borovčanin <[email protected]>
@dborovcanin dborovcanin deleted the update/protoc-version branch February 17, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants