Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-898 - Add transactions to postgres connect #940

Merged
merged 3 commits into from
Nov 11, 2019
Merged

MF-898 - Add transactions to postgres connect #940

merged 3 commits into from
Nov 11, 2019

Conversation

nwneisen
Copy link
Contributor

@nwneisen nwneisen commented Nov 8, 2019

Signed-off-by: Nick Neisen [email protected]

What does this do?

Adds transactions to connect code for bulk inserts at the database level.

Which issue(s) does this PR fix/relate to?

Relates to #898.

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Single connection tests were modified for bulk connections.

Did you document any new/modified functionality?

Code comments where changed to reflect bulk inserts.

Notes

@nwneisen nwneisen requested a review from a team as a code owner November 8, 2019 02:02
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #940 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files          75       75           
  Lines        5254     5254           
=======================================
  Hits         4395     4395           
  Misses        590      590           
  Partials      269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8dd4b...4ccaaaa. Read the comment docs.

anovakovic01
anovakovic01 previously approved these changes Nov 11, 2019
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 5446d88 into absmach:master Nov 11, 2019
@nwneisen nwneisen deleted the MF-898 branch November 11, 2019 17:28
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Add transactions to postgres connect

Signed-off-by: Nick Neisen <[email protected]>

* Change to use shorthand notation

Signed-off-by: Nick Neisen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants