-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-898 - Add transactions to postgres connect #940
Conversation
Signed-off-by: Nick Neisen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 75 75
Lines 5254 5254
=======================================
Hits 4395 4395
Misses 590 590
Partials 269 269 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Nick Neisen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add transactions to postgres connect Signed-off-by: Nick Neisen <[email protected]> * Change to use shorthand notation Signed-off-by: Nick Neisen <[email protected]>
Signed-off-by: Nick Neisen [email protected]
What does this do?
Adds transactions to connect code for bulk inserts at the database level.
Which issue(s) does this PR fix/relate to?
Relates to #898.
List any changes that modify/break current functionality
None
Have you included tests for your changes?
Single connection tests were modified for bulk connections.
Did you document any new/modified functionality?
Code comments where changed to reflect bulk inserts.
Notes