Deterministic hashing for tensors #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshitaB
approved these changes
Sep 12, 2022
| @@ -82,9 +94,12 @@ def det_hash_object(self) -> Any: | |||
| return None # When you return `None` from here, it falls back to just hashing the object itself. | |||
|
|
|||
|
|
|||
| _PICKLE_PROTOCOL = 4 | |||
There was a problem hiding this comment.
Can probably select protocol 5, since we require the minimum Python version to be 3.8.
|
Hmm, that would break all backwards compatibility though. All hashes of
existing projects would change.
…On Mon, Sep 12, 2022, 00:15 Akshita Bhagia ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Minor comment about the pickle protocol.
------------------------------
In tango/common/det_hash.py
<#398 (comment)>:
> @@ -82,9 +94,12 @@ def det_hash_object(self) -> Any:
return None # When you return `None` from here, it falls back to just hashing the object itself.
+_PICKLE_PROTOCOL = 4
Can probably select protocol 5, since we require the minimum Python
version to be 3.8.
—
Reply to this email directly, view it on GitHub
<#398 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHAYPSMY4QFQ7QFBAV4C4LV53KATANCNFSM6AAAAAAQI7JSZQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.