Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell step + Registrable functions #521

Merged
merged 16 commits into from
Feb 6, 2023
Merged

Shell step + Registrable functions #521

merged 16 commits into from
Feb 6, 2023

Conversation

AkshitaB
Copy link
Contributor

@AkshitaB AkshitaB commented Feb 4, 2023

This PR adds a basic version of a shell step.
It also makes adding registrable functions (so they can be referred in tango configs) simpler.

TODO: separate out the registrable function stuff, as it's broader.

@AkshitaB AkshitaB requested review from epwalsh and dirkgr February 4, 2023 02:04
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I have a few suggestions though

@AkshitaB AkshitaB requested a review from epwalsh February 6, 2023 22:44
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AkshitaB AkshitaB merged commit c949416 into main Feb 6, 2023
@AkshitaB AkshitaB deleted the shell-step branch February 6, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants