HADOOP-19446. ABFS: [FnsOverBlob][Tests] Add Tests For Negative Scenarios Identified for Delete Operation #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
manika137
changed the title
Test Results============================================================
|
anujmodi2021
requested changes
Feb 25, 2025
| Assertions.assertThat(testClient.deleteIdempotencyCheckOp(op) | ||
| .getResult() | ||
| .getStatusCode()) | ||
| .describedAs( |
| @@ -286,6 +304,7 @@ public void testDeleteIdempotencyTriggerHttp404() throws Exception { | |||
| doReturn(idempotencyRetOp).when(mockClient).deleteIdempotencyCheckOp(any()); | |||
| TracingContext tracingContext = getTestTracingContext(fs, false); | |||
| doReturn(tracingContext).when(idempotencyRetOp).createNewTracingContext(any()); | |||
| //To-discuss: If DFS service type, this if case can be removed? | |||
| fs.create(p1); | ||
| fs.create(p2); | ||
| AbfsBlobClient client = (AbfsBlobClient) fs.getAbfsClient(); | ||
| client.deleteBlobPath(p, null, |
There was a problem hiding this comment.
How is this delete on a file in implicit dir?
fs.create() will create explicit dir right?
There was a problem hiding this comment.
Like discussed- using azcopy commands for creating implicit files now
| Assertions.assertThat(!fs.exists(p1)) | ||
| .describedAs("FileStatus of the deleted directory should not exist.") | ||
| .isTrue(); | ||
| Assertions.assertThat(!fs.exists(p1)) |
|
|
||
| Path p = new Path("/nonExistingPath"); | ||
| intercept(FileNotFoundException.class, | ||
| () -> assertDeleted(fs, p, true)); |
There was a problem hiding this comment.
can we simply call fs.delete() here?
| fs.delete(testFile, false); | ||
|
|
||
| intercept(FileNotFoundException.class, | ||
| () -> assertDeleted(fs, testFile, true)); |
| @@ -359,6 +494,11 @@ public void testDeleteImplicitDir() throws Exception { | |||
| AbfsBlobClient client = (AbfsBlobClient) fs.getAbfsClient(); | |||
| client.deleteBlobPath(new Path("/testDir/dir1"), | |||
| null, getTestTracingContext(fs, true)); | |||
|
|
|||
| //Deleting non-empty dir with recursion set as | |||
There was a problem hiding this comment.
Why this needed?
Also the test name says deleting implicit dir but it seems like it is deleting explicit dir only.
There was a problem hiding this comment.
This is for the case with implicit path with children and recursion false
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
manika137
force-pushed
the
HADOOP-19446_NewDeleteTests
branch
from
5f4494e to
9fd8db0
Compare
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19446
We have identified a few scenarios worth adding integration or mocked behavior tests for while implementing FNS Support over Blob Endpoint. This PR adds tests for the negative scenarios identified for the delete operation particularly.
Test results added in the comment below.