[SPARK-51334][CONNECT] Add java/scala version in analyze spark_version response #50102
+162
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlandz-db
changed the title
garlandz-db
changed the title
|
I think we could add some tests here to verify the change in the response? |
HyukjinKwon
changed the title
|
@the-sakthi do you know where i can write them? im not seeing a relevant test suite that already includes tests for analyze plan handler |
grundprinzip
reviewed
Mar 3, 2025
grundprinzip
approved these changes
Mar 3, 2025
| @@ -261,6 +261,10 @@ message AnalyzePlanResponse { | |||
|
|
|||
| message SparkVersion { | |||
| string version = 1; | |||
| // The java version the Spark Connect Service is built with. | |||
There was a problem hiding this comment.
Is this correct, @garlandz-db ?
dongjoon-hyun
requested changes
Mar 3, 2025
dongjoon-hyun
requested changes
Mar 3, 2025
There was a problem hiding this comment.
In addition to #50102 (review), this PR seems to cause a semantic confusion to SparkConnect eco-system because SparkVersion is completely irrelevant from the underlying runtime Java version which can be Java 17 or Java 21.
message SparkVersion {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
No