[SPARK-51380][SQL] Make sure JDBC dialect could check the supported functions by Introduce functionToSQL and aggregateFunctionToSQL #50143
+30
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions by Introduce functionToSQL and aggregateFunctionToSQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make sure JDBC dialect could check the supported functions by Introduce
functionToSQLandaggregateFunctionToSQL.Why are the changes needed?
The original
visitSQLFunctionofJDBCSQLBuilderprovides the check about the supported functions. But many subclass ofJDBCSQLBuilderoverrides thevisitSQLFunctionand skips the check.This PR introduces
functionToSQLandaggregateFunctionToSQLin order to subclass to override.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.