Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback for get hypervisor type and eni ipv4 limits #1616

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

jayanthvn
Copy link
Contributor

What type of PR is this?
Bug

Which issue does this PR fix:
For new instances get hypervisor type and get eni ipv4 limit will fail

What does this PR do / Why do we need it:
Fallback for get instance type

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

{"level":"debug","ts":"2021-09-13T21:19:38.935Z","caller":"awsutils/awsutils.go:1317","msg":"Instance type limits are missing from vpc_ip_limits.go hence making an EC2 call to fetch the limits"}
{"level":"debug","ts":"2021-09-13T21:19:39.902Z","caller":"ipamd/ipamd.go:365","msg":"Instance hypervisor family nitro"}
{"level":"info","ts":"2021-09-13T21:19:39.902Z","caller":"ipamd/ipamd.go:374","msg":"Prefix Delegation enabled false"}
{"level":"debug","ts":"2021-09-13T21:19:39.902Z","caller":"ipamd/ipamd.go:379","msg":"Start node init"}

Automation added to e2e:

No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:

No
Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jayanthvn jayanthvn merged commit fe0a9be into aws:master Sep 14, 2021
jayanthvn added a commit to jayanthvn/amazon-vpc-cni-k8s that referenced this pull request Sep 14, 2021
* Fallback for hypervisor type and ipv4enilimit for new instances

* Update a debug

* Move fetch to common location

* Updated Uts
jayanthvn added a commit that referenced this pull request Sep 14, 2021
* Fallback for hypervisor type and ipv4enilimit for new instances

* Update a debug

* Move fetch to common location

* Updated Uts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants