-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove set -x from bash, add -Ss to curl #1802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks Skippy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the curl -Ss
addition.
I sometimes find the set -x
useful while looking at the logs (to see the command that was executed after the various substitutions). I am good with this change.
* VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]>
* Change workflow to use git install (aws#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (aws#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (aws#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (aws#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (aws#1818) * remove set -x from bash, add -Ss to curl (aws#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go
* Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Updated config files for v1.10.2
* Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Updated config files for v1.10.2 * Updated changelog for v1.10.2
* Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Updated config files for v1.10.2 * Changelog updates * rremove duplicate AWS_CLUSTER_ID from cni-metrics-helper manifest file
* Change workflow to use git install (aws#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (aws#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (aws#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (aws#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (aws#1818) * remove set -x from bash, add -Ss to curl (aws#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go
* Change workflow to use git install (aws#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (aws#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (aws#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (aws#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (aws#1818) * remove set -x from bash, add -Ss to curl (aws#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go Updated config files for v1.10.2 Changelog updates fixed empty netns bug (aws#1941) minor logging change Updated GO SDK added c7g instance PD on bare metal instance fixed dependabot warning
* Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go Updated config files for v1.10.2 Changelog updates fixed empty netns bug (#1941) minor logging change Updated GO SDK added c7g instance PD on bare metal instance fixed dependabot warning * Updated go.mod and go.sum
* Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Updated config files for v1.10.2 * Changelog updates * Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go Updated config files for v1.10.2 Changelog updates fixed empty netns bug (#1941) minor logging change Updated GO SDK added c7g instance PD on bare metal instance fixed dependabot warning * Updated go.mod and go.sum * sync upload-resources-to-github file with master
* Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Updated config files for v1.10.2 * Changelog updates * Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go * Cherry pick of workflow changes from master branch (#1793) * Change workflow to use git install (#1785) - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Workflow file updates (#1787) * Change workflow to use git install - Change workflow to use git install as the go get command was altering go.mod file without updating go.sum file * Update workflow files to use go 1.16 - Updated workflow files to use go 1.16 for consistency. - Changed integ test script to use git commit id and deleted unused code * Specify go version at 1.16 for workflow files Cherry pick multi-arch changes in release branch 1.10.2 changes (#1830) * VlanID changes PPSG Test agent changes CNI metrics helper changes minor fix Move logging for CLUSTER_ID and Region inside publisher.go from main.go revert manifest changes as the image is not released yet * Cherry pick multi-arch changes in release branch * cni-metrics-helper changes vlanID changes disable network provisioning fix ipamd error code fix * Minor change * remove redundant changes * Go version changes * Switch to public ECR for AL2 (#1804) * Switch to public ecr for al2 image - Removed docker_arch variable which is redundant with this change * Fix makefile and dockerfile entries * Merge changes to auto-sync manifests * minor change: add ContainerID to dummyVlanInterface * Remove sudo from workflow files (#1818) * remove set -x from bash, add -Ss to curl (#1802) * remove weekly-cron-test.yml as its not needed for this branch Co-authored-by: Vikas Basavaraj <[email protected]> Co-authored-by: Jayanth Varavani <[email protected]> Co-authored-by: Scott Merrill <[email protected]> fixed conflicts with routed-eni-cni-plugin/cni.go Updated config files for v1.10.2 Changelog updates fixed empty netns bug (#1941) minor logging change Updated GO SDK added c7g instance PD on bare metal instance fixed dependabot warning * Updated go.mod and go.sum * Updated Chart and appversion for vpc-cni
What type of PR is this?
cleanup
Which issue does this PR fix:
#1801
What does this PR do / Why do we need it:
While not catastrophic, it's sub-optimal for the
init.sh
script to emit diagnostic data to stderr. This PR removes the-x
from the Bashset
command.-x
is great for debugging and troubleshooting, but probably not necessary in the normal course of operations of this script.I also added
-Ss
to the twocurl
calls ininit.sh
. This suppresses the status output going to stderr, but will still emit errors in the event of actual errors. This is consistent with othercurl
calls within this repo.Testing done on this change:
N/A
Automation added to e2e:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
It ought not. I have not tested this yet, as I don't currently have sufficient scaffolding to do so.
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes, insofar as messages that had been emitted previously will no longer be emitted. If someone was expecting / relying on those messages for some purpose, those expectations won't be satisfied.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.