Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests a bit #580

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Improve tests a bit #580

merged 1 commit into from
Aug 7, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Aug 7, 2019

Issue #, if available: Follow up to #576

Description of changes:

  • Add unit tests for file copying
  • Change sleep timeouts from 5 to 0 seconds (Saves over 100 seconds when running tests)
  • Update makefile to run tests for all packages
  • Add vendor folder to .dockerignore

Added test:

docker run -e GO111MODULE=on \
		amazon-k8s-cni-test:latest make unit-test
GOOS=linux CGO_ENABLED=1 go test -v -cover github.com/aws/amazon-vpc-cni-k8s github.com/aws/amazon-vpc-cni-k8s/client/health-check github.com/aws/amazon-vpc-cni-k8s/cni-metrics-helper github.com/aws/amazon-vpc-cni-k8s/cni-metrics-helper/metrics github.com/aws/amazon-vpc-cni-k8s/ipamd github.com/aws/amazon-vpc-cni-k8s/ipamd/datastore github.com/aws/amazon-vpc-cni-k8s/pkg/apis/crd/v1alpha1 github.com/aws/amazon-vpc-cni-k8s/pkg/awsutils github.com/aws/amazon-vpc-cni-k8s/pkg/awsutils/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/cninswrapper github.com/aws/amazon-vpc-cni-k8s/pkg/cninswrapper/mock_ns github.com/aws/amazon-vpc-cni-k8s/pkg/cninswrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/ec2metadata github.com/aws/amazon-vpc-cni-k8s/pkg/ec2metadata/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/ec2metadatawrapper github.com/aws/amazon-vpc-cni-k8s/pkg/ec2metadatawrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/ec2wrapper github.com/aws/amazon-vpc-cni-k8s/pkg/ec2wrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/eniconfig github.com/aws/amazon-vpc-cni-k8s/pkg/eniconfig/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/grpcwrapper github.com/aws/amazon-vpc-cni-k8s/pkg/grpcwrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/httpwrapper github.com/aws/amazon-vpc-cni-k8s/pkg/httpwrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/ioutilwrapper github.com/aws/amazon-vpc-cni-k8s/pkg/ioutilwrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/ipwrapper github.com/aws/amazon-vpc-cni-k8s/pkg/ipwrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/k8sapi github.com/aws/amazon-vpc-cni-k8s/pkg/k8sapi/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/netlinkwrapper github.com/aws/amazon-vpc-cni-k8s/pkg/netlinkwrapper/mock_netlink github.com/aws/amazon-vpc-cni-k8s/pkg/netlinkwrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/netlinkwrapper/mocks_link github.com/aws/amazon-vpc-cni-k8s/pkg/networkutils github.com/aws/amazon-vpc-cni-k8s/pkg/networkutils/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/nswrapper github.com/aws/amazon-vpc-cni-k8s/pkg/nswrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/publisher github.com/aws/amazon-vpc-cni-k8s/pkg/publisher/mock_publisher github.com/aws/amazon-vpc-cni-k8s/pkg/rpcwrapper github.com/aws/amazon-vpc-cni-k8s/pkg/rpcwrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/typeswrapper github.com/aws/amazon-vpc-cni-k8s/pkg/typeswrapper/mocks github.com/aws/amazon-vpc-cni-k8s/pkg/utils github.com/aws/amazon-vpc-cni-k8s/pkg/utils/logger github.com/aws/amazon-vpc-cni-k8s/pkg/utils/ttime github.com/aws/amazon-vpc-cni-k8s/pkg/utils/ttime/mocks github.com/aws/amazon-vpc-cni-k8s/plugins/routed-eni github.com/aws/amazon-vpc-cni-k8s/plugins/routed-eni/driver github.com/aws/amazon-vpc-cni-k8s/plugins/routed-eni/driver/mocks github.com/aws/amazon-vpc-cni-k8s/rpc github.com/aws/amazon-vpc-cni-k8s/rpc/mocks github.com/aws/amazon-vpc-cni-k8s/scripts
=== RUN   Test_copyFileContents
=== RUN   Test_copyFileContents/Missing_file
=== RUN   Test_copyFileContents/Copy_executable
=== RUN   Test_copyFileContents/Copy_regular-file
1565208719844147400 [Debug] Copied file from "./testdata/executable" to "/tmp/executable"
--- PASS: Test_copyFileContents (0.01s)
    --- PASS: Test_copyFileContents/Missing_file (0.00s)
    --- PASS: Test_copyFileContents/Copy_executable (0.01s)
    --- PASS: Test_copyFileContents/Copy_regular-file (0.00s)   

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren added the testing label Aug 7, 2019
@mogren mogren added this to the v1.6 milestone Aug 7, 2019
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mogren mogren merged commit 0ab1343 into aws:master Aug 7, 2019
@mogren mogren deleted the more-tests branch September 26, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants