Fixes: internal representation of cgroups hierarchical structure #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @0x7f454c46 , @avagin Can you please check my PR. |
|
gentle ping : - ) CC: @0x7f454c46 , @avagin Can you please check my 1 line PR. |
|
@dschervov Please revise the commit message to align with our contributing guidelines. See |
strstartswith() function is incorrect choice for finding parent directory so i change it to issubpath() function Signed-off-by: Dmitrii Chervov <[email protected]>
Yes, thank you for information! My bad : - ( I rename my commit message |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do i want:
I want to fix bug in function "find_dir()". Then CRIU add cgroups it search
parent directory for cgroup to add it in the correct place. But function
that check it - "strstartswith()" is incorrent in this context. For example:
New cgroup: /dsch_tasks
Existent cgroup: /dsch
The "strstartswith" will return TRUE (which is ok) but in our context
/dsch is not parent directory for /dsch_tasks.
Thats why i cannot restore my application. So i want to fix this bug:
"(00.002162) Error (criu/cgroup.c:1766): cg: failed to open cg dir fd
(freezer//dsch/tasks) for chowning: Not a directory"
How i want to do it:
I replace "strstartswith()" on to "issubpath()" function.
It is written exactly for this purpose.
Signed-off-by: Dmitrii Chervov [email protected]